From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751259AbcEDEJt (ORCPT ); Wed, 4 May 2016 00:09:49 -0400 Received: from helcar.hengli.com.au ([209.40.204.226]:53910 "EHLO helcar.hengli.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751155AbcEDEJr (ORCPT ); Wed, 4 May 2016 00:09:47 -0400 Date: Wed, 4 May 2016 12:09:44 +0800 From: Herbert Xu To: Muhammad Falak R Wani Cc: davem@davemloft.net, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] crypto: algif_skcipher: replace sg++ with sg_next() Message-ID: <20160504040944.GA25781@gondor.apana.org.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1462301939-23578-1-git-send-email-falakreyaz@gmail.com> Organization: Core X-Newsgroups: apana.lists.os.linux.cryptoapi,apana.lists.os.linux.kernel User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Muhammad Falak R Wani wrote: > Never use sg++, always use sg = sg_next(sg). Scatterlist entries can > be combined if the memory is contiguous but sg++ won't know about > that. It sure would run on the slower side. > But regardless, sg++ should never be used, only sg_next is safe. > > Signed-off-by: Muhammad Falak R Wani No please the only difference between sg_next and sg++ is chaining, which is irrelevant here. Patch rejected. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt