From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752656AbcEDMUr (ORCPT ); Wed, 4 May 2016 08:20:47 -0400 Received: from mail.skyhub.de ([78.46.96.112]:48252 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750961AbcEDMUp (ORCPT ); Wed, 4 May 2016 08:20:45 -0400 Date: Wed, 4 May 2016 14:20:42 +0200 From: Borislav Petkov To: Matt Fleming Cc: linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org, Ard Biesheuvel , Kweh Hock Leong , "Bryan O'Donoghue" , joeyli Subject: Re: [PATCH] efi/capsule: Make efi_capsule_pending() lockless Message-ID: <20160504122042.GB4074@pd.tnic> References: <1462054407-9735-1-git-send-email-matt@codeblueprint.co.uk> <20160503090229.GC27540@pd.tnic> <20160503141201.GW2839@codeblueprint.co.uk> <20160504093031.GA4074@pd.tnic> <20160504114605.GH2839@codeblueprint.co.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20160504114605.GH2839@codeblueprint.co.uk> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 04, 2016 at 12:46:05PM +0100, Matt Fleming wrote: > But emergency_restart() is called after bust_spinlocks(0) which can > reset oops_in_progress, so can't even use that to solve the panic > case. Blergh. So I guess you need an explicit call efi_stop_capsules() somewhere in the reboot path and be done with it. No reboot notifiers, no bla bla. Just one big hammer which STFU the EFI. -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply.