From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756585AbcEEIG5 (ORCPT ); Thu, 5 May 2016 04:06:57 -0400 Received: from mx2.suse.de ([195.135.220.15]:33839 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755902AbcEEIDw (ORCPT ); Thu, 5 May 2016 04:03:52 -0400 Date: Thu, 5 May 2016 10:03:46 +0200 From: Jan Kara To: Toshi Kani Cc: Dave Chinner , dan.j.williams@intel.com, jack@suse.cz, hch@infradead.org, boaz@plexistor.com, tytso@mit.edu, adilger.kernel@dilger.ca, ross.zwisler@linux.intel.com, micah.parrish@hpe.com, linux-nvdimm@ml01.01.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 3/3] xfs: Add alignment check for DAX mount Message-ID: <20160505080346.GB1970@quack2.suse.cz> References: <1462214578-27122-1-git-send-email-toshi.kani@hpe.com> <1462214578-27122-4-git-send-email-toshi.kani@hpe.com> <20160504231855.GA26977@dastard> <1462405286.27137.88.camel@hpe.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1462405286.27137.88.camel@hpe.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed 04-05-16 17:41:26, Toshi Kani wrote: > On Thu, 2016-05-05 at 09:18 +1000, Dave Chinner wrote: > > On Mon, May 02, 2016 at 12:42:58PM -0600, Toshi Kani wrote: > > > > : > > Please write a helper along the lines of: > > > > error = blkdev_supports_dax(sb->s_bdev, sb->s_blocksize); > > > > and encapsulate all this, including the specific error messages in the > > helper (i.e. "Block device %s does not support DAX."). Then the rest > > of the filesystem code looks something like this: > > > > if (mp->m_flags & XFS_MOUNT_DAX) { > > error = blkdev_supports_dax(sb->s_bdev, sb->s_blocksize); > > if (error) { > > xfs_alert(mp, > > "DAX unsupported by block device. Turning off DAX."); > > mp->m_flags &= ~XFS_MOUNT_DAX; > > } > > } > > > > And each filesystem can choose to do what it wants with the error > > without having to care exactly why DAX is not supported. > > Yes, I had this change in mind and was wondering if you are OK with it > since I am incline to keep the ext2/4 message style as majority rule. :) > https://lkml.org/lkml/2016/5/3/543 > > Assuming that's OK, I will make this change. Yeah, just send me ext2 changes on top of your v2 and I can pull it to my tree. Honza -- Jan Kara SUSE Labs, CR