From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757193AbcEEPc4 (ORCPT ); Thu, 5 May 2016 11:32:56 -0400 Received: from smtprelay0075.hostedemail.com ([216.40.44.75]:51338 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753786AbcEEPcz (ORCPT ); Thu, 5 May 2016 11:32:55 -0400 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1431:1437:1515:1516:1518:1534:1539:1593:1594:1711:1730:1747:1777:1792:2198:2199:2393:2553:2559:2562:2693:2731:2904:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3870:3871:3872:3874:4362:5007:6261:7514:7875:8531:10004:10400:10848:10967:11026:11232:11658:11914:12043:12438:12517:12519:12740:13069:13311:13357:13439:14181:14659:14721:21080:30012:30025:30054:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: clam86_3635e89bc2d32 X-Filterd-Recvd-Size: 1716 Date: Thu, 5 May 2016 11:32:51 -0400 From: Steven Rostedt To: Alexei Starovoitov Cc: linux-kernel@vger.kernel.org, Ingo Molnar , Andrew Morton , Alexei Starovoitov Subject: Re: [for-next][PATCH 2/2] tracing: Use temp buffer when filtering events Message-ID: <20160505113251.71f2e60d@gandalf.local.home> In-Reply-To: <20160505152055.GA72567@ast-mbp.thefacebook.com> References: <20160504135202.422290539@goodmis.org> <20160504135241.308454993@goodmis.org> <20160505152055.GA72567@ast-mbp.thefacebook.com> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 5 May 2016 08:20:57 -0700 Alexei Starovoitov wrote: > tricky :) Thanks ;-) > so the buffer is used only for non-recursive events. > If the 2nd event on the same cpu also needs filtering it will > be going through normal trace_buffer_lock_reserve() path, > but then it means such events will be out of order if both > are accepted, right? > Is that a concern or not? Well, what is the order? Think about it, what's the difference if the interrupt came in just before the trace or just after? It still came in the same location with respect to the normal flow of the code. The only difference is, where we recorded it. -- Steve