From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754466AbcEELtu (ORCPT ); Thu, 5 May 2016 07:49:50 -0400 Received: from mail-wm0-f66.google.com ([74.125.82.66]:33417 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750900AbcEELtt (ORCPT ); Thu, 5 May 2016 07:49:49 -0400 Date: Thu, 5 May 2016 13:49:46 +0200 From: Michal Hocko To: Yang Shi Cc: cl@linux.com, penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, akpm@linux-foundation.org, hannes@cmpxchg.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linaro-kernel@lists.linaro.org Subject: Re: [PATCH] mm: slab: remove ZONE_DMA_FLAG Message-ID: <20160505114946.GI4386@dhcp22.suse.cz> References: <1462381297-11009-1-git-send-email-yang.shi@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1462381297-11009-1-git-send-email-yang.shi@linaro.org> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed 04-05-16 10:01:37, Yang Shi wrote: > Now we have IS_ENABLED helper to check if a Kconfig option is enabled or not, > so ZONE_DMA_FLAG sounds no longer useful. > > And, the use of ZONE_DMA_FLAG in slab looks pointless according to the > comment [1] from Johannes Weiner, so remove them and ORing passed in flags with > the cache gfp flags has been done in kmem_getpages(). > > [1] https://lkml.org/lkml/2014/9/25/553 I haven't checked the patch but I have a formal suggestion. lkml.org tends to break and forget, please use http://lkml.kernel.org/r/$msg-id instead. In this case http://lkml.kernel.org/r/20140925185047.GA21089@cmpxchg.org Thanks! -- Michal Hocko SUSE Labs