From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758602AbcEFQ4r (ORCPT ); Fri, 6 May 2016 12:56:47 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:46754 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755370AbcEFQ4p convert rfc822-to-8bit (ORCPT ); Fri, 6 May 2016 12:56:45 -0400 Date: Fri, 06 May 2016 12:56:42 -0400 (EDT) Message-Id: <20160506.125642.581240999988344349.davem@davemloft.net> To: linus.luessing@c0d3.blue Cc: netdev@vger.kernel.org, stephen@networkplumber.org, bridge@lists.linux-foundation.org, linux-kernel@vger.kernel.org, sw@simonwunderlich.de Subject: Re: [PATCHv2 net] bridge: fix igmp / mld query parsing From: David Miller In-Reply-To: <1462375502-8381-1-git-send-email-linus.luessing@c0d3.blue> References: <1462375502-8381-1-git-send-email-linus.luessing@c0d3.blue> X-Mailer: Mew version 6.6 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=iso-8859-1 Content-Transfer-Encoding: 8BIT X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 06 May 2016 09:56:44 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Linus Lüssing Date: Wed, 4 May 2016 17:25:02 +0200 > With the newly introduced helper functions the skb pulling is hidden > in the checksumming function - and undone before returning to the > caller. > > The IGMP and MLD query parsing functions in the bridge still > assumed that the skb is pointing to the beginning of the IGMP/MLD > message while it is now kept at the beginning of the IPv4/6 header. > > If there is a querier somewhere else, then this either causes > the multicast snooping to stay disabled even though it could be > enabled. Or, if we have the querier enabled too, then this can > create unnecessary IGMP / MLD query messages on the link. > > Fixing this by taking the offset between IP and IGMP/MLD header into > account, too. > > Fixes: 9afd85c9e455 ("net: Export IGMP/MLD message validation code") > Reported-by: Simon Wunderlich > Signed-off-by: Linus Lüssing Applied and queued up for -stable, thanks.