From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757720AbcEFKoq (ORCPT ); Fri, 6 May 2016 06:44:46 -0400 Received: from mail.skyhub.de ([78.46.96.112]:36608 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751874AbcEFKop (ORCPT ); Fri, 6 May 2016 06:44:45 -0400 Date: Fri, 6 May 2016 12:44:38 +0200 From: Borislav Petkov To: Ingo Molnar Cc: Kees Cook , torvalds@linux-foundation.org, hpa@zytor.com, dyoung@redhat.com, tglx@linutronix.de, luto@kernel.org, peterz@infradead.org, dvlasenk@redhat.com, linux-kernel@vger.kernel.org, brgerst@gmail.com, luto@amacapital.net, akpm@linux-foundation.org, bhe@redhat.com, yinghai@kernel.org, vgoyal@redhat.com, linux-tip-commits@vger.kernel.org Subject: Re: [tip:x86/boot] x86/boot: Clean up pointer casting Message-ID: <20160506104438.GF24044@pd.tnic> References: <1462486436-3707-2-git-send-email-keescook@chromium.org> <20160506085300.GE24044@pd.tnic> <20160506103619.GA8998@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20160506103619.GA8998@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 06, 2016 at 12:36:19PM +0200, Ingo Molnar wrote: > > Hm, your patch throws a lot of warnings during allnoconfig builds: > > In file included from arch/x86/boot/compressed/error.c:6:0: > arch/x86/boot/compressed/misc.h: In function ‘choose_random_location’: > arch/x86/boot/compressed/misc.h:83:9: warning: return makes pointer from integer > without a cast [-Wint-conversion] > return output_ptr; > ^ Blergh, that's when choose_random_location() is a stub and it needs to do return (unsigned char *)output_ptr; too. Lemme run all the *config builds on the fixed version before I send you a v2. Thanks. -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply.