From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932457AbcEFMhu (ORCPT ); Fri, 6 May 2016 08:37:50 -0400 Received: from mail-bl2on0071.outbound.protection.outlook.com ([65.55.169.71]:3192 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1758325AbcEFMhr (ORCPT ); Fri, 6 May 2016 08:37:47 -0400 Authentication-Results: huawei.com; dkim=none (message not signed) header.d=none;huawei.com; dmarc=none action=none header.from=caviumnetworks.com; Date: Fri, 6 May 2016 15:37:31 +0300 From: Yury Norov To: "Zhangjian (Bamvor)" CC: , , , , , , Hanjun Guo , , , , , , , , Andrew Pinski , , Andrew Pinski , , , , Subject: Re: [PATCH 20/25] arm64:ilp32: add sys_ilp32.c and a separate table (in entry.S) to use it Message-ID: <20160506123731.GA11959@yury-N73SV> References: <1459894127-17698-1-git-send-email-ynorov@caviumnetworks.com> <1459894127-17698-21-git-send-email-ynorov@caviumnetworks.com> <572C8B30.7000005@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <572C8B30.7000005@huawei.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-Originating-IP: [95.143.213.121] X-ClientProxiedBy: AM3PR08CA0018.eurprd08.prod.outlook.com (10.160.207.156) To DM3PR07MB2236.namprd07.prod.outlook.com (10.164.33.146) X-MS-Office365-Filtering-Correlation-Id: 80a9690d-dfca-4386-b405-08d375ab37f3 X-Microsoft-Exchange-Diagnostics: 1;DM3PR07MB2236;2:dqTwrzQjC7le5Bw6kjDEKtd1LoAw79KU/Hc/RvVSs7gkoVkm0HeInW6ZZYl1wRJu1Pl6RMaPV9Zh7qssGyuNw6PKMcilJKkzClgxkVG1dOjKTN3Iqs7wAxGYbpuU3uUuJf4LeUW0Brm63fHWMA8AuMCwTYW0ftDDpC8B4wLTIcMwyUDu6NOe6wKWW30H13Pt;3:kkSBDYWuV+G+X82q8svSv1+XtfK3usrJi40Ym3xLUeu+gajTvA1NTZ5WHu200InEZXAD43sGMs2H+Pw09DC+Qwdz/YIvTuJHya6CEAWAXO5hXG0J18hNZhFDJnFfxaHe X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DM3PR07MB2236; X-Microsoft-Exchange-Diagnostics: 1;DM3PR07MB2236;25:CFlWrYuiLoAtmh5CJUIUCQ8FpKGVrti2QixbYkK5CNEgGpnZVe79PHYCHLsd4hXszpFXEOtU3437diIi9gj5d7zAXzhkvsBUU+JWuEvZt0ay+0irfU6QxrBrBBYlN1vI3Oa/PkJUc7MS1QxWkjvYBxn+GnPSI81Qka6Qzo2mlT01gM0ZLD6MWmQeUDG9Cn0q+IJiNPEXSPqceFdOHpzJmj/kOWNViotptMmKPE544RXtXc1qjy7wM/iGBfbGEjikMEIjB/cmPCIRgthIRPWjKhj+LH61xpDMka3XrXCj0bOHU25EdLe4HdJkOgmktqTQKigYc9lARbThqjkpgdQGsZt5YbITmCrOl1BRkBMax0wB3oLnVLAQg6c3T/LsEyMnPi/fUTTKVzoyE0GiJzLfpxa4NlpaRLVOWz8qSM0/+5pfip3uZ9gxAg3tzbAZpxOGpjWxK/CzFNHa3hnQnTfkAUXQk3pOWCsVzCXd09Tbt91z20j6CQP8DVw6O0+nMFy5McxXsMh1brHQ8bLCoMMqTy+SSCKchksemHpIhD348NHbComuBBJ2Qrdln0oaig/E2hCDPV6jjwcyqICwsRGk9baW5aXKJe0Ah/5il7Vph/JZgtm1ymlHTJkODI20dUeF6mjr1wmx+l5SLY9ZOulLuQAIyZ1ohNbHb8t8a/rTi6iT01wDxCuh/aOiN6K94b8Pqf94CSMuKCoL/KnFNiVLe8QMuSQbzYvbSjgXQQDTBXBrCcoreHtgb8uiyTXxjSg6tyu8KItPSNDZui2eaetlHjPlFTV42NfXnGhWl1pS9KLE02kjJlkulE8UttVKIi+6NwTIBWHcvGWIaN2KqLO/LiSfufsKWghfsywzZuej4zk= X-Microsoft-Exchange-Diagnostics: 1;DM3PR07MB2236;20:oeMMBsKZYvOMStTAge1ZvRt9U4lWI+s0CAHFGtANUUBP2T+ptEkUKPjdsIQ47wKRpHCWR3GRtNpCguKrYtj2eyWkdmTNwdswiPzfeNFCy3gQIqOwaSQBgM9zDXQdhjAJk9ibOsfVvRFFUP+HaZCJat+Pbp0T81GZIPZ5KZEb97Sd/0u2haQ8YeHkL2Rlblii3N2Fj4+w3CGVkwZ5WmiBb+I6QDUTvukZfMfMq3lcPuzc4SeHIaWimuzp9ZtC/wT/BL4lL3iyvQC80Ny1MJ7UU7bOVN4SDkTFD7SQJBun9QkJNKe2QaGuAeBoEf7N2hMJooTQPSbWK7N6+EEZ555nvlyDGV6x0pcYPkgyF5FuSofZA6GH8INZnlSUnTvvEsdaHuGj1DCSfFwrr+x+bnpvbB+du3Y2Zhl2XWL31DonmzxXWf/JpyMkA7mNjLktOdwA1bwyKbiW1XJox0TeVts269KgpjG/u0r4j5qePO99jyxoR1BOGUZCYcpIEX9b6QnZE2dATBbd/dtwBABuyoZ6ETBpUIjk7y7ahZrhg/4T2ALYECIpGbXDr420r25iUK7X0XubiihOg/b1KNKgn6N/uGp8hmoR5whELnju9IiOqHI= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046);SRVR:DM3PR07MB2236;BCL:0;PCL:0;RULEID:;SRVR:DM3PR07MB2236; X-Microsoft-Exchange-Diagnostics: 1;DM3PR07MB2236;4:ClqGMN9mJK6YViK60VUx8eLOENKrmOAE+uCUeEye7grRZ4iHk9T2AL9HltA2apN/4KPR4pBFTQ/E/djEeY/6TgSTbjlvI1hFBTwbf2HmHGOHd5A1YgVtoWKt+Z0QJm0pKMmNbucTo9dD6K/SMrxpgbb45OvmihM6KaqDR6GlerTChhqhdZF9SXL0d85HyiNC+dsdWd4/w3EgcaYqoeG0scC1hczl4TLQQxo+PFQyY7caBbSaR9aoPJhOkKGI67OEjtmzIfWRIejR6k3F8ICA9oai4LF3gl3JOkjm0JFoanpdokSxaFO/p9riwxB2gMpTQqfSkK90Z4BvDv+FLHeaYl+lrG6KTeQHyXvtbD0CYCWuLEGU9WWsymzl8M9P+MzH X-Forefront-PRVS: 09347618C4 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(979002)(6009001)(6069001)(24454002)(5004730100002)(23726003)(76506005)(54356999)(76176999)(50986999)(1076002)(33656002)(81166005)(586003)(46406003)(4001350100001)(92566002)(9686002)(6116002)(3846002)(83506001)(2906002)(2950100001)(4326007)(1720100001)(15975445007)(77096005)(5008740100001)(33716001)(110136002)(189998001)(50466002)(47776003)(66066001)(42186005)(97756001)(19580395003)(19580405001)(2004002)(969003)(989001)(999001)(1009001)(1019001);DIR:OUT;SFP:1101;SCL:1;SRVR:DM3PR07MB2236;H:localhost;FPR:;SPF:None;MLV:ovrnspm;PTR:InfoNoRecords;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;DM3PR07MB2236;23:HWiOgWvEcof4WPW5oN2bRJ9kyLcqn7pKNG7Q17ZsN?= =?us-ascii?Q?yOYQx5p5sIg+i1laKmHxA1B+hQUoS5Bevl9h8Pzb99oQdGd+4KwKt6dGxl9W?= =?us-ascii?Q?ec8aUlxU4doKKHwQXNVNhyEOsjxPTHSkYhrqM53kbtGmNfZ74HflrQlhQImM?= =?us-ascii?Q?WnNK/J5ACk6blQh0Tya8pkhWJxp9VPN8NFP5gVhxBLVdE9UuTyc0W9qoEUX6?= =?us-ascii?Q?yht+B0OzPAgWHGFwHlXBL6R+3nK9xBGd6Tk6o/nzK13jE9M4DrnPWsTTXwVG?= =?us-ascii?Q?h3KGUSGnEQRECaRPccDRt1T6kvMgH8lM0ZT/gQrr3+3B8WGiq6drQ6AxxT7+?= =?us-ascii?Q?U9/aPC63iUKzzxyabWGo6C7zSb+kTdLMJfLedF9MxF6MqRCg3Zrz8b8DAVa1?= =?us-ascii?Q?Ejy3GuiwPM41tmqGcNLrWtJD09JtDqScnvrAyJFcjxXu9ZhFPoV9bihGTuZI?= =?us-ascii?Q?c/rDX7pQGImcOsNRfL1QQFKOR/mx/8VYbVqT1Aakq6bwwNp9Lf7uMm4v/2ix?= =?us-ascii?Q?5HQXOGTfFmjPFv0bV5m/29xE0/qKj6mdsdVoF4bFYT3rgjfA6RBdKre2qyrU?= =?us-ascii?Q?MlVG/dxviSi/6Dj5tMDbyunZBe7fI7zz7y7MGOdjXBGR0oyffhsqwsckVK03?= =?us-ascii?Q?n3dz+6uwjLpQtcmO/VuS61okGRO+CWCyp7hMKd6JeAZo0K7xy4MUvteTs05Y?= =?us-ascii?Q?J3jfMPtE6dghaciwrU4y0LL5ZMOxHScP0a6sGM1V5H9IUlP8xiEFwMPQp6Ze?= =?us-ascii?Q?t/evtY29pIUIG/S+HX4v8IVilj3c4Nt0HX6elgCafPAdz8b603uGpu0uwJv2?= =?us-ascii?Q?z2Jgy8OgWtgCJuljxJmKS1Q7qa+OTrYZNDykpWKOrwlIP6Vho+PBQMLbxLOp?= =?us-ascii?Q?bEK85Riy4rrJEfcRPfbyPrv9b8untHeOu32VNhAuCPrB7AmvQSqYaw8+FTck?= =?us-ascii?Q?YNY7g7m4+JY0a/hMHq+uN4hZJStW1w5L6Dx0pvdBwROQf4hj0xU+xSHZ2JHB?= =?us-ascii?Q?DT2eyhDa1sA8KRs9+9ejsmUNPivgcHX0E3L+vP2JbsuH4HbU6a1sfnOqfeHx?= =?us-ascii?Q?h5v7CyNmsLOeP1sVZ8pXK20QHrLxTUwCWKVM7IYIG/asw5fHcGiNKG/k/oUp?= =?us-ascii?Q?YFR+2xcE3ABuwgmI8rbNW03aQZNQ0Ur?= X-Microsoft-Exchange-Diagnostics: 1;DM3PR07MB2236;5:8PASjYz6cT77vSkDGiks7JhxnLWVWso8htC4ndb6mS5zENT2CmEcG3NAO8H6WCLJTNVqG5Gov0QxTpoxMq4lLhWTm7dYj87QYp1ZR/cnQnTnFmGwLbd2Vybys4TlKWLLxpNq/jjH/65kcPD/VWhrpQ==;24:Ul4lgenU7GwUdGii+MU1N4OMiTcb97PX6E30qJ/q+XFMbExMuOBgTKTNnQ9qQn8PRzTQsQFTNwbT/Q0VBna0V5qREtzJ3E564YYIheVRHjc=;7:0ufbjL2R4vHBNBjuD9+5JjimcjGuKNIgcs0kMkr+qKYdplsLL27HAPA0h+VXurzt3WoEDxuRT2Eu3rk+3Xld2469+2U5cc9iFgFruxh5iRZOfO8h4P3vNHMGKwUODnQorO+Da7cAzVxm1NqNI23Uh8AMprMp7cfONLYcnocdde6AXvQ4pGr4VzULoO4wk0rn SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 May 2016 12:37:42.2791 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM3PR07MB2236 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 06, 2016 at 08:16:48PM +0800, Zhangjian (Bamvor) wrote: > Hi, > > On 2016/4/6 6:08, Yury Norov wrote: > >From: Andrew Pinski > > > >Add a separate syscall-table for ILP32, which dispatches either to native > >LP64 system call implementation or to compat-syscalls, as appropriate. > > > >Signed-off-by: Andrew Pinski > >Signed-off-by: Yury Norov > >--- > > arch/arm64/include/asm/unistd.h | 11 ++++++- > > arch/arm64/kernel/Makefile | 2 +- > > arch/arm64/kernel/entry.S | 12 +++++++- > > arch/arm64/kernel/sys_ilp32.c | 65 +++++++++++++++++++++++++++++++++++++++++ > > 4 files changed, 87 insertions(+), 3 deletions(-) > > create mode 100644 arch/arm64/kernel/sys_ilp32.c > > > >diff --git a/arch/arm64/include/asm/unistd.h b/arch/arm64/include/asm/unistd.h > >index 2971dea..5ea18ef 100644 > >--- a/arch/arm64/include/asm/unistd.h > >+++ b/arch/arm64/include/asm/unistd.h > >@@ -13,9 +13,18 @@ > > * You should have received a copy of the GNU General Public License > > * along with this program. If not, see . > > */ > >+ > >+#ifdef CONFIG_COMPAT > >+#define __ARCH_WANT_COMPAT_STAT64 > >+#endif > >+ > >+#ifdef CONFIG_ARM64_ILP32 > >+#define __ARCH_WANT_COMPAT_SYS_PREADV64 > >+#define __ARCH_WANT_COMPAT_SYS_PWRITEV64 > >+#endif > >+ > > #ifdef CONFIG_AARCH32_EL0 > > #define __ARCH_WANT_COMPAT_SYS_GETDENTS64 > >-#define __ARCH_WANT_COMPAT_STAT64 > > #define __ARCH_WANT_SYS_GETHOSTNAME > > #define __ARCH_WANT_SYS_PAUSE > > #define __ARCH_WANT_SYS_GETPGRP > >diff --git a/arch/arm64/kernel/Makefile b/arch/arm64/kernel/Makefile > >index 9dfdf86..7aa65ea 100644 > >--- a/arch/arm64/kernel/Makefile > >+++ b/arch/arm64/kernel/Makefile > >@@ -28,7 +28,7 @@ $(obj)/%.stub.o: $(obj)/%.o FORCE > > arm64-obj-$(CONFIG_AARCH32_EL0) += sys32.o kuser32.o signal32.o \ > > sys_compat.o entry32.o \ > > ../../arm/kernel/opcodes.o binfmt_elf32.o > >-arm64-obj-$(CONFIG_ARM64_ILP32) += binfmt_ilp32.o > >+arm64-obj-$(CONFIG_ARM64_ILP32) += binfmt_ilp32.o sys_ilp32.o > > arm64-obj-$(CONFIG_FUNCTION_TRACER) += ftrace.o entry-ftrace.o > > arm64-obj-$(CONFIG_MODULES) += arm64ksyms.o module.o > > arm64-obj-$(CONFIG_ARM64_MODULE_PLTS) += module-plts.o > >diff --git a/arch/arm64/kernel/entry.S b/arch/arm64/kernel/entry.S > >index cf4d1ae..1f7a145 100644 > >--- a/arch/arm64/kernel/entry.S > >+++ b/arch/arm64/kernel/entry.S > >@@ -715,9 +715,13 @@ ENDPROC(ret_from_fork) > > */ > > .align 6 > > el0_svc: > >- adrp stbl, sys_call_table // load syscall table pointer > > uxtw scno, w8 // syscall number in w8 > > mov sc_nr, #__NR_syscalls > >+#ifdef CONFIG_ARM64_ILP32 > >+ ldr x16, [tsk, #TI_FLAGS] > >+ tbnz x16, #TIF_32BIT_AARCH64, el0_ilp32_svc // We are using ILP32 > >+#endif > >+ adrp stbl, sys_call_table // load syscall table pointer > > el0_svc_naked: // compat entry point > > stp x0, scno, [sp, #S_ORIG_X0] // save the original x0 and syscall number > > enable_dbg_and_irq > >@@ -737,6 +741,12 @@ ni_sys: > > b ret_fast_syscall > > ENDPROC(el0_svc) > > > >+#ifdef CONFIG_ARM64_ILP32 > >+el0_ilp32_svc: > >+ adrp stbl, sys_call_ilp32_table // load syscall table pointer > >+ b el0_svc_naked > >+#endif > >+ > > /* > > * This is the really slow path. We're going to be doing context > > * switches, and waiting for our parent to respond. > >diff --git a/arch/arm64/kernel/sys_ilp32.c b/arch/arm64/kernel/sys_ilp32.c > >new file mode 100644 > >index 0000000..0996d8e > >--- /dev/null > >+++ b/arch/arm64/kernel/sys_ilp32.c > >@@ -0,0 +1,65 @@ > >+/* > >+ * AArch64- ILP32 specific system calls implementation > >+ * > >+ * Copyright (C) 2016 Cavium Inc. > >+ * Author: Andrew Pinski > >+ * > >+ * This program is free software; you can redistribute it and/or modify > >+ * it under the terms of the GNU General Public License version 2 as > >+ * published by the Free Software Foundation. > >+ * > >+ * This program is distributed in the hope that it will be useful, > >+ * but WITHOUT ANY WARRANTY; without even the implied warranty of > >+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > >+ * GNU General Public License for more details. > >+ * > >+ * You should have received a copy of the GNU General Public License > >+ * along with this program. If not, see . > >+ */ > >+ > >+#include > >+#include > >+#include > >+#include > >+#include > >+#include > >+#include > >+#include > >+#include > >+#include > >+#include > >+ > >+/* Using non-compat syscalls where necessary */ > >+#define compat_sys_fadvise64_64 sys_fadvise64_64 > >+#define compat_sys_fallocate sys_fallocate > >+#define compat_sys_ftruncate64 sys_ftruncate > >+#define compat_sys_lookup_dcookie sys_lookup_dcookie > >+#define compat_sys_pread64 sys_pread64 > >+#define compat_sys_pwrite64 sys_pwrite64 > >+#define compat_sys_readahead sys_readahead > >+#define compat_sys_shmat sys_shmat > >+#define compat_sys_sync_file_range sys_sync_file_range > >+#define compat_sys_truncate64 sys_truncate > >+#define sys_llseek sys_lseek > >+#define sys_mmap2 sys_mmap > I am a little bit confused here. We wrap the mmap to mmap2 in glibc > without shift the 4096 and We map mmap2 to mmap in kernel which > means we shift with the real page size. It works unless the > application want to mmap the offset bigger then 2G. In ILP32 app, > if the offset is bigger than 2G(e.g. 0xfb000000), it is a negative > number and extend to 64bit nagetive number in kernel > (0xfffffff fb000000). I add the "COMPAT_SYSCALL_WRAP6(mmap, ...)" in > kernel/compat_wrapper.c. But it is not works. I am not sure if it is > already sign extended in userspace. > > On the other hand, I read the code of mmap in arm and other > architecture. Usually, they will shift 4096 in userspace and shift > others in kernel if needed. Should we follow the similar ways or we > could call mmap_pgoff in glibc and do the shift according the real > page shift(getpages())? > > Thanks > > Bamvor > > Hi, AFAIR, here we don't shift offset, as it's 64-bit both in user- and kernel-space, and just pass it from user to kernel thru glibc with no changes. It definitely works, as there are many mappings made by linker and libc in 2G+ area, and there are no problems with them. This is a typical ILP32 application map: 00400000-00401000 r-xp 00000000 08:00 130400 /root/mykill 00410000-00411000 rwxp 00000000 08:00 130400 /root/mykill 00527000-00549000 rwxp 00000000 00:00 0 [heap] c6278000-c6298000 rwxp 00000000 00:00 0 c6298000-c63d0000 r-xp 00000000 08:00 135293 /root/sys-root/libilp32/libc-2.22.so c63d0000-c63e0000 ---p 00138000 08:00 135293 /root/sys-root/libilp32/libc-2.22.so c63e0000-c63e2000 r-xp 00138000 08:00 135293 /root/sys-root/libilp32/libc-2.22.so c63e2000-c63e3000 rwxp 0013a000 08:00 135293 /root/sys-root/libilp32/libc-2.22.so c63e3000-c63e6000 rwxp 00000000 00:00 0 c63e6000-c63fc000 r-xp 00000000 08:00 135313 /root/sys-root/libilp32/libpthread-2.22.so c63fc000-c640b000 ---p 00016000 08:00 135313 /root/sys-root/libilp32/libpthread-2.22.so c640b000-c640c000 r-xp 00015000 08:00 135313 /root/sys-root/libilp32/libpthread-2.22.so c640c000-c640d000 rwxp 00016000 08:00 135313 /root/sys-root/libilp32/libpthread-2.22.so c640d000-c640f000 rwxp 00000000 00:00 0 c640f000-c642c000 r-xp 00000000 08:00 135288 /root/sys-root/libilp32/ld-2.22.so c6437000-c6439000 rwxp 00000000 00:00 0 c6439000-c643a000 r--p 00000000 00:00 0 [vvar] c643a000-c643b000 r-xp 00000000 00:00 0 [vdso] c643b000-c643c000 r-xp 0001c000 08:00 135288 /root/sys-root/libilp32/ld-2.22.so c643c000-c643d000 rwxp 0001d000 08:00 135288 /root/sys-root/libilp32/ld-2.22.so ffe2d000-ffe4e000 rw-p 00000000 00:00 0 [stack] > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel