From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758005AbcEFLUb (ORCPT ); Fri, 6 May 2016 07:20:31 -0400 Received: from web1.dommelhosting.nl ([88.159.17.71]:34871 "EHLO web1.dommelhosting.nl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757007AbcEFLU1 convert rfc822-to-8bit (ORCPT ); Fri, 6 May 2016 07:20:27 -0400 X-Footer: dmFubWllcmxvLmNvbQ== To: "Andy Shevchenko" , "Bryan O'Donoghue" , "Peter Hurley" , linux-serial@vger.kernel.org, "Vinod Koul" , linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org, "Greg Kroah-Hartman" , ismo.puustinen@intel.com, "Heikki Krogerus" From: "Maarten Brock" Subject: Re: [PATCH v3 03/11] dmaengine: dw: set polarity of handshake interface X-Mailer: Kerio Connect 8.5.0 WebMail Mini Message-ID: <20160506132019.019e5db0@kerio.vanmierlo.com> Date: Fri, 06 May 2016 13:20:19 +0200 X-User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/49.0.2623.112 Safari/537.36 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ----- Original Message ----- From: Andy Shevchenko [mailto:andriy.shevchenko@linux.intel.com] To: Bryan O'Donoghue [mailto:pure.logic@nexus-software.ie], Peter Hurley [mailto:peter@hurleysoftware.com], linux-serial@vger.kernel.org, Vinod Koul [mailto:vinod.koul@intel.com], linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org, Greg Kroah-Hartman [mailto:gregkh@linuxfoundation.org], ismo.puustinen@intel.com, Heikki Krogerus [mailto:heikki.krogerus@linux.intel.com] Sent: Fri, 06 May 2016 12:42:00 +0200 Subject: Re: [PATCH v3 03/11] dmaengine: dw: set polarity of handshake interface > On Thu, 2016-05-05 at 18:54 +0100, Bryan O'Donoghue wrote: > > On Wed, 2016-04-27 at 16:48 +0300, Andy Shevchenko wrote: > > > > > > +       bool                    polarity; > > So this variable is not very intuitively named. > > There is a help above. This is a property of the Synopsys DesignWare DMA > engine. Anyone familiar with datasheet easily understands this. > > > > > You end up setting somepointer->polarity = true; in a later patch.  > > > > Since you're respining a V4 I'd suggest a name that describes a little > > bit better than polarity. Setting polarity = true is a little bit > > liked being asked "you you like ice-cream or apple pie" and then > > saying "yes please". > > It's about handshake interface polarity, so, what about hs_polarity? So it means: handshake has polarity (true) or handshake has no polarity (omnidirectional?) (false), right? Maarten