From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758054AbcEFOHG (ORCPT ); Fri, 6 May 2016 10:07:06 -0400 Received: from mail-wm0-f67.google.com ([74.125.82.67]:35629 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757007AbcEFOHD (ORCPT ); Fri, 6 May 2016 10:07:03 -0400 Date: Fri, 6 May 2016 16:07:01 +0200 From: Daniel Vetter To: Thierry Reding Cc: Noralf =?iso-8859-1?Q?Tr=F8nnes?= , treding@nvidia.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH 4/4] drm/panel: Add helper for simple panel connector Message-ID: <20160506140701.GC27098@phenom.ffwll.local> Mail-Followup-To: Thierry Reding , Noralf =?iso-8859-1?Q?Tr=F8nnes?= , treding@nvidia.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org References: <1462454674-2246-1-git-send-email-noralf@tronnes.org> <1462454674-2246-5-git-send-email-noralf@tronnes.org> <20160505170321.GO1286@phenom.ffwll.local> <2a8224c5-d95e-273a-59ff-c6372b7c01a0@tronnes.org> <20160506140137.GA4641@ulmo.ba.sec> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20160506140137.GA4641@ulmo.ba.sec> X-Operating-System: Linux phenom 4.6.0-rc5+ User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 06, 2016 at 04:01:37PM +0200, Thierry Reding wrote: > On Fri, May 06, 2016 at 03:39:53PM +0200, Noralf Trønnes wrote: > > > > Den 05.05.2016 19:03, skrev Daniel Vetter: > > > On Thu, May 05, 2016 at 03:24:34PM +0200, Noralf Trønnes wrote: > > > > Add function to create a simple connector for a panel. > > > > > > > > Signed-off-by: Noralf Trønnes > > > Like in the previous patch please also add a new section for the panel > > > helpers to gpu.tmpl. I don't think this needs an overview section, it's so > > > simple. But adding some cross references from the drm_panel.c kerneldoc to > > > this and back would be real good. > > > > drm_panel.c doesn't have any documentation and the header file has only > > the drm_panel_funcs struct documented, not hooked up to gpu.tmpl. > > > > I can make a patch documenting the functions, it looks fairly straight > > forward, but I have no idea what to put in the DOC: section, except an > > xref to this helper :-) > > Maybe now is a good time for me to post the below. I really should've > sent this out ages ago, sorry. > > Thierry > --- >8 --- > From 77057510413f8ca52d37da883afeabb13031ec63 Mon Sep 17 00:00:00 2001 > From: Thierry Reding > Date: Tue, 4 Nov 2014 15:23:10 +0100 > Subject: [PATCH] drm/panel: Flesh out kerneldoc > > Write more complete kerneldoc comments for the DRM panel API and > integrate the helpers in the DRM DocBook reference. > > Signed-off-by: Thierry Reding Applied to drm-msic, thanks. > --- > Documentation/DocBook/gpu.tmpl | 12 ++++++--- > drivers/gpu/drm/drm_panel.c | 61 ++++++++++++++++++++++++++++++++++++++++++ > include/drm/drm_panel.h | 59 ++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 129 insertions(+), 3 deletions(-) > > diff --git a/Documentation/DocBook/gpu.tmpl b/Documentation/DocBook/gpu.tmpl > index 1464fb2f3c46..fb4ad6945a97 100644 > --- a/Documentation/DocBook/gpu.tmpl > +++ b/Documentation/DocBook/gpu.tmpl > @@ -1671,17 +1671,23 @@ void intel_crt_init(struct drm_device *dev) > !Pdrivers/gpu/drm/drm_crtc.c Tile group > > > - Bridges > + Bridges > > - Overview > + Overview > !Pdrivers/gpu/drm/drm_bridge.c overview > > > - Default bridge callback sequence > + Default bridge callback sequence > !Pdrivers/gpu/drm/drm_bridge.c bridge callbacks > > !Edrivers/gpu/drm/drm_bridge.c > > + > + Panel Helper Reference > +!Iinclude/drm/drm_panel.h > +!Edrivers/gpu/drm/drm_panel.c > +!Pdrivers/gpu/drm/drm_panel.c drm panel > + Hm, since you call this a helper, and we already have a Kconfig for it I guess would make sense to put Noralf's connector-for-panel helper in there too? -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch