From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758557AbcEFQmZ (ORCPT ); Fri, 6 May 2016 12:42:25 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:58608 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756308AbcEFQmX (ORCPT ); Fri, 6 May 2016 12:42:23 -0400 Date: Fri, 6 May 2016 17:42:08 +0100 From: Mark Brown To: "Opensource [Adam Thomson]" Cc: Liam Girdwood , Jaroslav Kysela , Takashi Iwai , "alsa-devel@alsa-project.org" , "linux-kernel@vger.kernel.org" , Support Opensource , Sathyanarayana Nujella Message-ID: <20160506164208.GV6292@sirena.org.uk> References: <20160506123909.GT6292@sirena.org.uk> <2E89032DDAA8B9408CB92943514A0337D463C303@SW-EX-MBX01.diasemi.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="S+p9DbwVuimCDe+R" Content-Disposition: inline In-Reply-To: <2E89032DDAA8B9408CB92943514A0337D463C303@SW-EX-MBX01.diasemi.com> X-Cookie: Use in well-ventilated area. User-Agent: Mutt/1.6.0 (2016-04-01) X-SA-Exim-Connect-IP: 2a01:348:6:8808:fab::3 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH 2/3] ASoC: da7219: Add ACPI parsing support X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --S+p9DbwVuimCDe+R Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, May 06, 2016 at 02:45:00PM +0000, Opensource [Adam Thomson] wrote: > On May 06, 2016, 13:39, Mark Brown wrote: > > > - /* Handle any DT/platform data */ > > > - if ((codec->dev->of_node) && (da7219->pdata)) > > > + /* Handle any DT/ACPI/platform data */ > > > + if (((codec->dev->of_node) || is_acpi_node(codec->dev->fwnode)) && > > > + (da7219->pdata)) > > > da7219->pdata->aad_pdata = da7219_aad_of_to_pdata(codec); > > > da7219_aad_handle_pdata(codec); > > Surely we should be able to check if there's firmware data without > > enumerating every possible firmware type? > There doesn't seem to be a unified check for this. Also, Given these are the > only two types the driver expects and supports right now, I don't see a problem > being explicit here in the checking. Again it's pointing out something that looks like it's missing from the fwnode API - if people are supposed to be able to write firmware neutral drivers they should be able to do everything they need at the fwnode level. --S+p9DbwVuimCDe+R Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJXLMlfAAoJECTWi3JdVIfQXOgH/34y5Cdv00qQtzfpM/JSaw1n ZY7acdExkDDgSMmGK/QT/caLRPx1a2wO1mA67XlCI8DoPtENeRCvatBtnmK6hnDr 6JZh6sW9pvEPMKUWsXMc7edhgqpMlkO3gamU7Ie82w9KE0CCJuvGD8vcxLEuqd+e rgAkb4wLOnvwpEOVwggcnYowhss6VHeOVUpv5nRtp8ft08r/lXvtB3KTyRLnU7MZ 0gKUsIGrt25JGFh4Hf7qOgy+Yp9vBiNbKWU2ClhEm231Vv5DPYc9vOh35wkM+cjD fRDhNBu9v6kk1H5yAtMjZc6XobQELR/ZYvm6DqllvBF67LFTujk8WNXxEjpF7XQ= =T58q -----END PGP SIGNATURE----- --S+p9DbwVuimCDe+R--