From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751186AbcEGTQa (ORCPT ); Sat, 7 May 2016 15:16:30 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:35564 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751135AbcEGTQ3 (ORCPT ); Sat, 7 May 2016 15:16:29 -0400 Date: Sat, 07 May 2016 15:16:21 -0400 (EDT) Message-Id: <20160507.151621.585688267278016986.davem@davemloft.net> To: dan.carpenter@oracle.com Cc: manish.chopra@qlogic.com, sony.chacko@qlogic.com, rajesh.borundia@qlogic.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [patch] netxen: netxen_rom_fast_read() doesn't return -1 From: David Miller In-Reply-To: <20160505132019.GD3038@mwanda> References: <20160505132019.GD3038@mwanda> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sat, 07 May 2016 12:16:23 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dan Carpenter Date: Thu, 5 May 2016 16:20:20 +0300 > The error handling is broken here. netxen_rom_fast_read() returns zero > on success and -EIO on error. It never returns -1. > > Signed-off-by: Dan Carpenter Applied.