From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750904AbcEHSFy (ORCPT ); Sun, 8 May 2016 14:05:54 -0400 Received: from down.free-electrons.com ([37.187.137.238]:46137 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750849AbcEHSFx (ORCPT ); Sun, 8 May 2016 14:05:53 -0400 Date: Sun, 8 May 2016 20:05:50 +0200 From: Maxime Ripard To: Arnd Bergmann Cc: David Airlie , Chen-Yu Tsai , Boris Brezillon , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm: sun4i: fix probe error handling Message-ID: <20160508180550.GB6167@lukather> References: <1462479061-893414-1-git-send-email-arnd@arndb.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="LpQ9ahxlCli8rRTG" Content-Disposition: inline In-Reply-To: <1462479061-893414-1-git-send-email-arnd@arndb.de> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --LpQ9ahxlCli8rRTG Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, May 05, 2016 at 10:10:52PM +0200, Arnd Bergmann wrote: > gcc points out a possible uninitialized variable use in > sun4i_dclk_create(): >=20 > drivers/gpu/drm/sun4i/sun4i_dotclock.c: In function 'sun4i_dclk_create': > drivers/gpu/drm/sun4i/sun4i_dotclock.c:139:12: error: 'clk_name' may be u= sed uninitialized in this function [-Werror=3Dmaybe-uninitialized] > init.name =3D clk_name; >=20 > The warning only shows up when CONFIG_OF is disabled, and the > property is never filled, but the same bug can show up even > when CONFIG_OF is enabled but of_property_read_string_index > returns another error. >=20 > To fix it, this ensures that sun4i_dclk_create propagates > any error from of_property_read_string_index. >=20 > Signed-off-by: Arnd Bergmann > Fixes: 9026e0d122ac ("drm: Add Allwinner A10 Display Engine support") Applied, thanks Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com --LpQ9ahxlCli8rRTG Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJXL3/+AAoJEBx+YmzsjxAgD8gQAMEEhIZ1Q+/EISobqEoZ3W1P MbsQJLVU2YykqnI6mvfC6jAbwtzNPrIHzBsjmPmBRvgyNC3ipKdCP5FV0Is6lTFM /2TSCPS4mkRJKTPiRXnO6fy7QWHpJ+GKPZm6nHMC/8g+Ci4RHffDneUarG2QBJGo uVpTrIuVnQe1A/phzia39el+1Z9vsvhgozXEYuuCQ+A3eGfALFW8d8nz+RVeOgN0 VPCZFAKjMtetzIwtmgKXCjsSDohTIqR3YUk78vXBj6RNhtpmPovm4O+ToAzxv21r xN4j/uqK4lsh1cPLr/WRUM1p1/GxpCkP/6oe/cUAoSXPf0VVAQ6ryynsFwGYjfbU 6iRgwYUvMo4gRKahhf+HDqAooR7BnpSZToiWhgi39tFAf6RIshoN4xMw6ezgRkS8 hxYTBxQ9Xw3anVUuimvCmCaKlVCNeujlm69iu7phqOaI2UDavE7vJixewBTpD4Rv D04cSUMrpMHqgVDf4MQxRja1W8LobiIgUMmAO73O9bSUfBsSgmDhjHhR9yt/WUbi HSM2kEm2VgHXi6yPKcnZL0woLpyGHpTxE50qmlth4dRYTywyHjC7PnOOWeEVnT7o vMU4ytk0pOvtJL1+X8zX3ILDVt/BnQEh70SMCow6sp9VzObCoPhuPDwSspyhnGSh MKd5G6TTNf1FITDv92U0 =Bz3U -----END PGP SIGNATURE----- --LpQ9ahxlCli8rRTG--