From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752780AbcEIHc2 (ORCPT ); Mon, 9 May 2016 03:32:28 -0400 Received: from mx2.suse.de ([195.135.220.15]:44462 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751600AbcEIHcZ (ORCPT ); Mon, 9 May 2016 03:32:25 -0400 Date: Mon, 9 May 2016 09:32:04 +0200 From: David Sterba To: Jiri Slaby Cc: gregkh@linuxfoundation.org, Jiri Kosina , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org Subject: Re: [PATCH 1/7] tty: ipwireless, cleanup TIOCGSERIAL Message-ID: <20160509073204.GI29353@suse.cz> Reply-To: dsterba@suse.cz Mail-Followup-To: dsterba@suse.cz, Jiri Slaby , gregkh@linuxfoundation.org, Jiri Kosina , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org References: <1462777919-10367-1-git-send-email-jslaby@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1462777919-10367-1-git-send-email-jslaby@suse.cz> User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 09, 2016 at 09:11:53AM +0200, Jiri Slaby wrote: > In ipwireless_get_serial_info, struct serial_struct is memset to 0 and > then some members set to 0 explicitly. > > Remove the latter as it is obviously superfluous. > > And remove the retinfo check against NULL. copy_to_user will take care > of that. > > Part of hub6 cleanup series. > > Signed-off-by: Jiri Slaby > Cc: Jiri Kosina > Cc: David Sterba Acked-by: David Sterba