From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751827AbcEJSQT (ORCPT ); Tue, 10 May 2016 14:16:19 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:41958 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751325AbcEJSQS (ORCPT ); Tue, 10 May 2016 14:16:18 -0400 Date: Tue, 10 May 2016 14:16:15 -0400 (EDT) Message-Id: <20160510.141615.174614051833919078.davem@davemloft.net> To: jslaby@suse.cz Cc: gregkh@linuxfoundation.org, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, samuel@sortiz.org, netdev@vger.kernel.org Subject: Re: [PATCH 2/7] net: ircomm, cleanup TIOCGSERIAL From: David Miller In-Reply-To: <1462777919-10367-2-git-send-email-jslaby@suse.cz> References: <1462777919-10367-1-git-send-email-jslaby@suse.cz> <1462777919-10367-2-git-send-email-jslaby@suse.cz> X-Mailer: Mew version 6.6 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 10 May 2016 11:16:17 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jiri Slaby Date: Mon, 9 May 2016 09:11:54 +0200 > In ircomm_tty_get_serial_info, struct serial_struct is memset to 0 and > then some members set to 0 explicitly. > > Remove the latter as it is obviously superfluous. > > And remove the retinfo check against NULL. copy_to_user will take care > of that. > > Part of hub6 cleanup series. > > Signed-off-by: Jiri Slaby Acked-by: David S. Miller