From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751454AbcEJJNh (ORCPT ); Tue, 10 May 2016 05:13:37 -0400 Received: from mx2.suse.de ([195.135.220.15]:60058 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751372AbcEJJNe (ORCPT ); Tue, 10 May 2016 05:13:34 -0400 Date: Tue, 10 May 2016 11:13:21 +0200 From: Johannes Thumshirn To: Jens Axboe Cc: Greg KH , Wenbo Wang , Wenbo Wang , linux-kernel@vger.kernel.org, stable@vger.kernel.org, keith.busch@intel.com, wenwei.tao@memblaze.com, linux-nvme@lists.infradead.org Subject: Re: [PATH v2] NVMe: init nvme queue before enabling irq Message-ID: <20160510091321.GC22590@c203.arch.suse.de> References: <1453286915-18814-1-git-send-email-mail_weber_wang@163.com> <20160120171223.GA28243@kroah.com> <569FC116.5060109@fb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <569FC116.5060109@fb.com> User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 20, 2016 at 10:17:10AM -0700, Jens Axboe wrote: > On 01/20/2016 10:12 AM, Greg KH wrote: > > On Wed, Jan 20, 2016 at 05:48:35AM -0500, Wenbo Wang wrote: > > > From: Wenbo Wang > > > > > > During reset process, the nvme_dev->bar (ioremapped) may change, > > > so nvmeq->q_db shall be also updated by nvme_init_queue(). > > > > > > Currently nvmeq irq is enabled before queue init, so a spurious > > > interrupt triggered nvme_process_cq may access nvmeq->q_db just > > > before it is updated, this could cause kernel panic. > > > > > > Signed-off-by: Wenbo Wang > > > Reviewed-by: Wenwei Tao > > > --- > > > drivers/nvme/host/pci.c | 14 +++++++++----- > > > 1 file changed, 9 insertions(+), 5 deletions(-) > > > > > > > > This is not the correct way to submit patches for inclusion in the > > stable kernel tree. Please read Documentation/stable_kernel_rules.txt > > for how to do this properly. > > I'll mark it stable when adding, just ignore it for now. > > -- > Jens Axboe > > > _______________________________________________ > Linux-nvme mailing list > Linux-nvme@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-nvme Ping? -- Johannes Thumshirn Storage jthumshirn@suse.de +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850