From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751531AbcEJIgE (ORCPT ); Tue, 10 May 2016 04:36:04 -0400 Received: from relay06.alfahosting-server.de ([109.237.142.242]:57980 "EHLO relay06.alfahosting-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751252AbcEJIgD convert rfc822-to-8bit (ORCPT ); Tue, 10 May 2016 04:36:03 -0400 X-Spam-DCC: : Date: Tue, 10 May 2016 10:36:25 +0200 From: Richard Leitner To: Andrew Morton Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH] mm/memblock.c: remove unnecessary always-true comparison Message-ID: <20160510103625.3a7f8f32@g0hl1n.net> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT X-Virus-Checker-Version: clamassassin 1.2.4 with ClamAV 0.97.3/21520/Mon May 9 18:49:50 2016 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Comparing an u64 variable to >= 0 returns always true and can therefore be removed. This issue was detected using the -Wtype-limits gcc flag. This patch fixes following type-limits warning: mm/memblock.c: In function ‘__next_reserved_mem_region’: mm/memblock.c:843:11: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits] if (*idx >= 0 && *idx < type->cnt) { Signed-off-by: Richard Leitner --- mm/memblock.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/memblock.c b/mm/memblock.c index b570ddd..a1b8549 100644 --- a/mm/memblock.c +++ b/mm/memblock.c @@ -840,7 +840,7 @@ void __init_memblock __next_reserved_mem_region(u64 *idx, { struct memblock_type *type = &memblock.reserved; - if (*idx >= 0 && *idx < type->cnt) { + if (*idx < type->cnt) { struct memblock_region *r = &type->regions[*idx]; phys_addr_t base = r->base; phys_addr_t size = r->size; -- 2.1.4