From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752728AbcEJOPx (ORCPT ); Tue, 10 May 2016 10:15:53 -0400 Received: from mx2.suse.de ([195.135.220.15]:49055 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751650AbcEJOPv (ORCPT ); Tue, 10 May 2016 10:15:51 -0400 Date: Tue, 10 May 2016 16:15:44 +0200 From: Jan Kara To: Vishal Verma Cc: linux-nvdimm@ml01.01.org, Dan Williams , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, xfs@oss.sgi.com, linux-ext4@vger.kernel.org, linux-mm@kvack.org, Ross Zwisler , Dave Chinner , Jan Kara , Jens Axboe , Andrew Morton , linux-kernel@vger.kernel.org, Christoph Hellwig , Jeff Moyer , Boaz Harrosh Subject: Re: [PATCH v5 1/5] dax: fallback from pmd to pte on error Message-ID: <20160510141544.GL11897@quack2.suse.cz> References: <1462571591-3361-1-git-send-email-vishal.l.verma@intel.com> <1462571591-3361-2-git-send-email-vishal.l.verma@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1462571591-3361-2-git-send-email-vishal.l.verma@intel.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri 06-05-16 15:53:07, Vishal Verma wrote: > From: Dan Williams > > In preparation for consulting a badblocks list in pmem_direct_access(), > teach dax_pmd_fault() to fallback rather than fail immediately upon > encountering an error. The thought being that reducing the span of the > dax request may avoid the error region. > > Signed-off-by: Dan Williams The patch looks good. You can add: Reviewed-by: Jan Kara Honza -- Jan Kara SUSE Labs, CR