From: Tejun Heo <tj@kernel.org>
To: Konstantin Khlebnikov <khlebnikov@yandex-team.ru>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Sasha Levin <sasha.levin@oracle.com>
Subject: Re: workqueue: race in mod_delayed_work_on?
Date: Tue, 10 May 2016 12:36:25 -0400 [thread overview]
Message-ID: <20160510163625.GM7110@mtj.duckdns.org> (raw)
In-Reply-To: <57320C18.3000909@yandex-team.ru>
Hello,
On Tue, May 10, 2016 at 07:28:08PM +0300, Konstantin Khlebnikov wrote:
> On 10.05.2016 11:21, Konstantin Khlebnikov wrote:
> >I've got plenty warnings, bugs and oops around trivial use of mod_delayed_work in drivers/infiniband/core/addr.c
>
> Looks like problem in mod_delayed_work_on was hidden because add_timer is equal to mod_timer
The timer usages are gated behind PENDING bit, so whether add_timer()
is equal to mod_timer() shouldn't matter.
> but Sasha accidentally backported 874bbfe600a660cba9c776b3957b1ce393151b76
> (workqueue: make sure delayed work run in local cpu) into 3.18.25
>
> I don't see reason why that commit could break delayed work,
> most likely it highlighted some other problem.
What are you running? Can you reproduce the issue on upstream kernel?
--
tejun
next prev parent reply other threads:[~2016-05-10 16:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-10 8:21 Konstantin Khlebnikov
2016-05-10 16:28 ` Konstantin Khlebnikov
2016-05-10 16:36 ` Tejun Heo [this message]
2016-05-10 17:20 ` Konstantin Khlebnikov
2016-05-12 13:06 ` Konstantin Khlebnikov
2016-05-13 13:49 ` Konstantin Khlebnikov
2016-05-15 16:08 ` Konstantin Khlebnikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160510163625.GM7110@mtj.duckdns.org \
--to=tj@kernel.org \
--cc=khlebnikov@yandex-team.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=sasha.levin@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®