mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alex Thorlton <athorlton@sgi.com>
To: Matt Fleming <matt@codeblueprint.co.uk>
Cc: Alex Thorlton <athorlton@sgi.com>, Borislav Petkov <bp@suse.de>,
	linux-kernel@vger.kernel.org,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
	x86@kernel.org, linux-efi@vger.kernel.org,
	Russ Anderson <rja@sgi.com>, Dimitri Sivanich <sivanich@sgi.com>,
	mike travis <travis@sgi.com>, Nathan Zimmer <nzimmer@sgi.com>
Subject: Re: [BUG] x86/efi: MMRs no longer properly mapped after switch to isolated page table
Date: Tue, 10 May 2016 12:35:11 -0500	[thread overview]
Message-ID: <20160510173511.GI113599@stormcage.americas.sgi.com> (raw)
In-Reply-To: <20160509215524.GQ2839@codeblueprint.co.uk>

On Mon, May 09, 2016 at 10:55:24PM +0100, Matt Fleming wrote:
> On Mon, 02 May, at 04:39:31PM, Alex Thorlton wrote:
> > 
> > If you think we're violating EFI rules by accessing these registers from
> > both sides of the fence, please let me know.  I'd like to make sure that
> > we get everything behaving the way it should be!
> 
> Oh no, I don't think this is violating the UEFI spec at all, but I do
> think it goes against the spirit of the way other implementations are
> designed; with maximum separation between firmware and kernel.

Understood.  Thanks!

> In a perfect world, I'd suggest mapping the MMR range in both the
> kernel and firmware, at different virtual address ranges, but have
> the firmware's version opaque to the kernel and only described by an
> EfiMemoryMappedIO region, or something. That is ignoring any region
> type conflicts that may arise.

The code I'm working on right now will do exactly this, so I think we're
on the right track there.  My solution is still a bit hacky, and we're
still working out some kinks with runtime EFI calls, but we're getting
closer.

I will send up an RFC patch with my findings as soon as we've worked out
our callback issues.  I'm working with our BIOS guys on this as we
speak.

Thanks again for the help, Matt!

- Alex

  reply	other threads:[~2016-05-10 17:35 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-27 15:41 Alex Thorlton
2016-04-27 18:23 ` Alex Thorlton
2016-04-27 22:51 ` Borislav Petkov
2016-04-28  1:41   ` Alex Thorlton
2016-04-28 12:57     ` Borislav Petkov
2016-04-29 15:41       ` Alex Thorlton
2016-04-30 22:12         ` Matt Fleming
2016-05-02 21:39           ` Alex Thorlton
2016-05-02 22:17             ` Mike Travis
2016-05-09 21:55             ` Matt Fleming
2016-05-10 17:35               ` Alex Thorlton [this message]
2016-05-02 10:02         ` Borislav Petkov
2016-05-02 22:27           ` Alex Thorlton
2016-05-03  0:10             ` Alex Thorlton
2016-05-03  9:48               ` Borislav Petkov
2016-05-03 18:47                 ` Alex Thorlton
2016-05-04 10:36                   ` Borislav Petkov
2016-05-04 16:32                     ` Alex Thorlton
2016-04-29  9:01 ` Matt Fleming
2016-04-29 15:45   ` Alex Thorlton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160510173511.GI113599@stormcage.americas.sgi.com \
    --to=athorlton@sgi.com \
    --cc=bp@suse.de \
    --cc=hpa@zytor.com \
    --cc=linux-efi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matt@codeblueprint.co.uk \
    --cc=mingo@redhat.com \
    --cc=nzimmer@sgi.com \
    --cc=rja@sgi.com \
    --cc=sivanich@sgi.com \
    --cc=tglx@linutronix.de \
    --cc=travis@sgi.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®