From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752196AbcEJSVz (ORCPT <rfc822;w@1wt.eu>);
	Tue, 10 May 2016 14:21:55 -0400
Received: from mezzanine.sirena.org.uk ([106.187.55.193]:40840 "EHLO
	mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751807AbcEJSVy (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 10 May 2016 14:21:54 -0400
Date: Tue, 10 May 2016 19:21:43 +0100
From: Mark Brown <broonie@kernel.org>
To: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>, Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>, alsa-devel@alsa-project.org,
        linux-kernel@vger.kernel.org,
        Support Opensource <support.opensource@diasemi.com>
Message-ID: <20160510182143.GD6261@sirena.org.uk>
References: <cover.1462892732.git.Adam.Thomson.Opensource@diasemi.com>
 <5e2ccd9429829fc8cacf94ee8595efa6d11834f4.1462892732.git.Adam.Thomson.Opensource@diasemi.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="8nsIa27JVQLqB7/C"
Content-Disposition: inline
In-Reply-To: <5e2ccd9429829fc8cacf94ee8595efa6d11834f4.1462892732.git.Adam.Thomson.Opensource@diasemi.com>
X-Cookie: When in doubt, follow your heart.
User-Agent: Mutt/1.6.0 (2016-04-01)
X-SA-Exim-Connect-IP: 94.175.94.161
X-SA-Exim-Mail-From: broonie@sirena.org.uk
Subject: Re: [PATCH 2/5] ASoC: da7213: Add checking of SRM lock status before
 enabling DAI
X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000)
X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


--8nsIa27JVQLqB7/C
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, May 10, 2016 at 04:11:05PM +0100, Adam Thomson wrote:

> +		/* Slave mode, if SRM not enabled no need for status checks */
> +		pll_ctrl = snd_soc_read(codec, DA7213_PLL_CTRL);
> +		if (!(pll_ctrl & DA7213_PLL_SRM_EN))
> +			return 0;

This isn't going to work, the driver has no volatile registers but it
does have a cache...

--8nsIa27JVQLqB7/C
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEcBAEBCAAGBQJXMia1AAoJECTWi3JdVIfQy8sH/1RkSBqqgAWZejmFRydhOQm2
q6MOSXt9hdlfFwmYakhCfLgmkJnDoIpalGvDqKeuz3riR70VOY/QT+52D3oe2Q2c
G4QzuF459VXZSZsaytk5rNM9f/y7al7zgt3H44fS3Xrg9peTt1g4Vgn9bKTicc0l
kr+3yvdE0UuOlf79cEpydorPGV3wSNtZRgMkMuL/GS5XT8ALrS8xvwoftm2ce4FA
mz8UiQsZpQ34luuRWbukk/oOG1/X1Bsr96+gjUMMnx7qZnRyDxtyHp5gDgN9jFgm
pfxeGvCQ2u4iDfsfcjm8nyevqYpwTURuJ3e7ft3Ak+YAcqmyJPKNYK+wPLQ6xEI=
=tx1E
-----END PGP SIGNATURE-----

--8nsIa27JVQLqB7/C--