mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Aurelien Jarno <aurelien@aurel32.net>
To: Paul Burton <paul.burton@imgtec.com>
Cc: linux-mips@linux-mips.org, Ralf Baechle <ralf@linux-mips.org>,
	"stable # v4 . 0+" <stable@vger.kernel.org>,
	Adam Buchbinder <adam.buchbinder@gmail.com>,
	linux-kernel@vger.kernel.org,
	James Hogan <james.hogan@imgtec.com>
Subject: Re: [PATCH 1/2] MIPS: Disable preemption during prctl(PR_SET_FP_MODE, ...)
Date: Tue, 10 May 2016 21:32:46 +0200	[thread overview]
Message-ID: <20160510193246.GB7635@aurel32.net> (raw)
In-Reply-To: <1461239038-19991-1-git-send-email-paul.burton@imgtec.com>

On 2016-04-21 12:43, Paul Burton wrote:
> Whilst a PR_SET_FP_MODE prctl is performed there are decisions made
> based upon whether the task is executing on the current CPU. This may
> change if we're preempted, so disable preemption to avoid such changes
> for the lifetime of the mode switch.
> 
> Signed-off-by: Paul Burton <paul.burton@imgtec.com>
> Fixes: 9791554b45a2 ("MIPS,prctl: add PR_[GS]ET_FP_MODE prctl options for MIPS")
> Cc: stable <stable@vger.kernel.org> # v4.0+
> ---
> 
>  arch/mips/kernel/process.c | 4 ++++
>  1 file changed, 4 insertions(+)

Both patches fixes building pillow, which otherwise hangs running
"python setup.py build" [1]. The setup code uses the multiprocessing
package, and it hangs in a call to PR_SET_FP_MODE.

You can therefore add for both patches:

Tested-by: Aurelien Jarno <aurelien@aurel32.net>

Thanks,
Aurelien

[1] https://buildd.debian.org/status/fetch.php?pkg=pillow&arch=mips&ver=3.2.0-1&stamp=1460852908

-- 
Aurelien Jarno                          GPG: 4096R/1DDD8C9B
aurelien@aurel32.net                 http://www.aurel32.net

      parent reply	other threads:[~2016-05-10 20:15 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-21 11:43 Paul Burton
2016-04-21 11:43 ` [PATCH 2/2] MIPS: Force CPUs to lose FP context during mode switches Paul Burton
2016-04-22 16:06   ` Maciej W. Rozycki
2016-04-22 16:00 ` [PATCH 1/2] MIPS: Disable preemption during prctl(PR_SET_FP_MODE, ...) Maciej W. Rozycki
2016-05-10 19:32 ` Aurelien Jarno [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160510193246.GB7635@aurel32.net \
    --to=aurelien@aurel32.net \
    --cc=adam.buchbinder@gmail.com \
    --cc=james.hogan@imgtec.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@linux-mips.org \
    --cc=paul.burton@imgtec.com \
    --cc=ralf@linux-mips.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®