From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752654AbcEJVwS (ORCPT ); Tue, 10 May 2016 17:52:18 -0400 Received: from bh-25.webhostbox.net ([208.91.199.152]:54607 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751579AbcEJVwR (ORCPT ); Tue, 10 May 2016 17:52:17 -0400 Date: Tue, 10 May 2016 14:51:57 -0700 From: Guenter Roeck To: Muhammad Falak R Wani Cc: Wim Van Sebroeck , linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] watchdog: cpwd: Use setup_timer() Message-ID: <20160510215157.GA19128@roeck-us.net> References: <1462539581-26207-1-git-send-email-falakreyaz@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1462539581-26207-1-git-send-email-falakreyaz@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-Authenticated_sender: guenter@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: guenter@roeck-us.net X-Authenticated-Sender: bh-25.webhostbox.net: guenter@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 06, 2016 at 06:29:40PM +0530, Muhammad Falak R Wani wrote: > The function setup_timer combines the initialization of a timer with > the initialization of the timer's function and data fields. > The multiline code for timer initialization is now replaced > with function setup_timer. > > Signed-off-by: Muhammad Falak R Wani Reviewed-by: Guenter Roeck > --- > drivers/watchdog/cpwd.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/watchdog/cpwd.c b/drivers/watchdog/cpwd.c > index 0200768..71ee079 100644 > --- a/drivers/watchdog/cpwd.c > +++ b/drivers/watchdog/cpwd.c > @@ -611,9 +611,7 @@ static int cpwd_probe(struct platform_device *op) > } > > if (p->broken) { > - init_timer(&cpwd_timer); > - cpwd_timer.function = cpwd_brokentimer; > - cpwd_timer.data = (unsigned long) p; > + setup_timer(&cpwd_timer, cpwd_brokentimer, (unsigned long)p); > cpwd_timer.expires = WD_BTIMEOUT; > > pr_info("PLD defect workaround enabled for model %s\n", > -- > 1.9.1 >