From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751617AbcEKHrd (ORCPT ); Wed, 11 May 2016 03:47:33 -0400 Received: from mail-wm0-f68.google.com ([74.125.82.68]:32868 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750954AbcEKHrc (ORCPT ); Wed, 11 May 2016 03:47:32 -0400 Date: Wed, 11 May 2016 09:47:30 +0200 From: Daniel Vetter To: Benjamin Gaignard Cc: Arnd Bergmann , David Airlie , Vincent Abriou , Fabien Dessenne , "Luis R. Rodriguez" , Daniel Vetter , Ville =?iso-8859-1?Q?Syrj=E4l=E4?= , Bich Hemon , Thierry Reding , Nicolas VANHAELEWYN , Carlos Palminha , "dri-devel@lists.freedesktop.org" , Linux Kernel Mailing List Subject: Re: [PATCH 2/2] drm/sti: include linux/seq_file.h where needed Message-ID: <20160511074729.GP27098@phenom.ffwll.local> Mail-Followup-To: Benjamin Gaignard , Arnd Bergmann , David Airlie , Vincent Abriou , Fabien Dessenne , "Luis R. Rodriguez" , Ville =?iso-8859-1?Q?Syrj=E4l=E4?= , Bich Hemon , Thierry Reding , Nicolas VANHAELEWYN , Carlos Palminha , "dri-devel@lists.freedesktop.org" , Linux Kernel Mailing List References: <1462830733-1710590-1-git-send-email-arnd@arndb.de> <1462830733-1710590-2-git-send-email-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Operating-System: Linux phenom 4.6.0-rc5+ User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 11, 2016 at 09:07:06AM +0200, Benjamin Gaignard wrote: > Acked-by: Benjamin Gaignard > > 2016-05-09 23:51 GMT+02:00 Arnd Bergmann : > > The sti drm driver has a lot of debugfs interface that cause > > build errors in some configurations when seq_file.h is not > > included implicitly: > > > > drm/sti/sti_mixer.c: In function 'mixer_dbg_ctl': > > drm/sti/sti_mixer.c:88:2: error: implicit declaration of function 'seq_puts' [-Werror=implicit-function-declaration] > > drm/sti/sti_mixer.c:91:4: error: implicit declaration of function 'seq_printf' [-Werror=implicit-function-declaration] > > drm/sti/sti_gdp.c: In function 'gdp_dbg_ctl': > > drm/sti/sti_gdp.c:146:2: error: implicit declaration of function 'seq_puts' [-Werror=implicit-function-declaration] > > drm/sti/sti_gdp.c:149:4: error: implicit declaration of function 'seq_printf' [-Werror=implicit-function-declaration] > > drm/sti/sti_gdp.c: In function 'gdp_dbg_show': > > drm/sti/sti_gdp.c:208:32: error: dereferencing pointer to incomplete type 'struct seq_file' > > > > This adds an explicit #include statement in all of the affected files. > > > > Signed-off-by: Arnd Bergmann Applied to drm-misc. -Daniel > > --- > > drivers/gpu/drm/sti/sti_cursor.c | 2 ++ > > drivers/gpu/drm/sti/sti_gdp.c | 1 + > > drivers/gpu/drm/sti/sti_hda.c | 1 + > > drivers/gpu/drm/sti/sti_hqvdp.c | 1 + > > drivers/gpu/drm/sti/sti_mixer.c | 1 + > > drivers/gpu/drm/sti/sti_tvout.c | 1 + > > drivers/gpu/drm/sti/sti_vid.c | 1 + > > 7 files changed, 8 insertions(+) > > > > diff --git a/drivers/gpu/drm/sti/sti_cursor.c b/drivers/gpu/drm/sti/sti_cursor.c > > index 3abb400151ac..4e990299735c 100644 > > --- a/drivers/gpu/drm/sti/sti_cursor.c > > +++ b/drivers/gpu/drm/sti/sti_cursor.c > > @@ -6,6 +6,8 @@ > > * License terms: GNU General Public License (GPL), version 2 > > */ > > > > +#include > > + > > #include > > #include > > #include > > diff --git a/drivers/gpu/drm/sti/sti_gdp.c b/drivers/gpu/drm/sti/sti_gdp.c > > index ff3d3e7e7704..ff33c38da197 100644 > > --- a/drivers/gpu/drm/sti/sti_gdp.c > > +++ b/drivers/gpu/drm/sti/sti_gdp.c > > @@ -5,6 +5,7 @@ > > * for STMicroelectronics. > > * License terms: GNU General Public License (GPL), version 2 > > */ > > +#include > > > > #include > > #include > > diff --git a/drivers/gpu/drm/sti/sti_hda.c b/drivers/gpu/drm/sti/sti_hda.c > > index ec0d017eaf1a..f7d3464cdf09 100644 > > --- a/drivers/gpu/drm/sti/sti_hda.c > > +++ b/drivers/gpu/drm/sti/sti_hda.c > > @@ -8,6 +8,7 @@ > > #include > > #include > > #include > > +#include > > > > #include > > #include > > diff --git a/drivers/gpu/drm/sti/sti_hqvdp.c b/drivers/gpu/drm/sti/sti_hqvdp.c > > index e05b0dc523ff..1edec29b9e45 100644 > > --- a/drivers/gpu/drm/sti/sti_hqvdp.c > > +++ b/drivers/gpu/drm/sti/sti_hqvdp.c > > @@ -7,6 +7,7 @@ > > #include > > #include > > #include > > +#include > > > > #include > > #include > > diff --git a/drivers/gpu/drm/sti/sti_mixer.c b/drivers/gpu/drm/sti/sti_mixer.c > > index e7425c38fc93..aed7801b51f7 100644 > > --- a/drivers/gpu/drm/sti/sti_mixer.c > > +++ b/drivers/gpu/drm/sti/sti_mixer.c > > @@ -5,6 +5,7 @@ > > * for STMicroelectronics. > > * License terms: GNU General Public License (GPL), version 2 > > */ > > +#include > > > > #include "sti_compositor.h" > > #include "sti_mixer.h" > > diff --git a/drivers/gpu/drm/sti/sti_tvout.c b/drivers/gpu/drm/sti/sti_tvout.c > > index 2c99016443e5..f983db5a59da 100644 > > --- a/drivers/gpu/drm/sti/sti_tvout.c > > +++ b/drivers/gpu/drm/sti/sti_tvout.c > > @@ -12,6 +12,7 @@ > > #include > > #include > > #include > > +#include > > > > #include > > #include > > diff --git a/drivers/gpu/drm/sti/sti_vid.c b/drivers/gpu/drm/sti/sti_vid.c > > index 5a2c5dc3687b..523ed19f5ac6 100644 > > --- a/drivers/gpu/drm/sti/sti_vid.c > > +++ b/drivers/gpu/drm/sti/sti_vid.c > > @@ -3,6 +3,7 @@ > > * Author: Fabien Dessenne for STMicroelectronics. > > * License terms: GNU General Public License (GPL), version 2 > > */ > > +#include > > > > #include > > > > -- > > 2.7.0 > > > > > > -- > Benjamin Gaignard > > Graphic Working Group > > Linaro.org │ Open source software for ARM SoCs > > Follow Linaro: Facebook | Twitter | Blog -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch