From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751492AbcEKIFK (ORCPT ); Wed, 11 May 2016 04:05:10 -0400 Received: from mail-bl2on0055.outbound.protection.outlook.com ([65.55.169.55]:40208 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751324AbcEKIFB (ORCPT ); Wed, 11 May 2016 04:05:01 -0400 Authentication-Results: huawei.com; dkim=none (message not signed) header.d=none;huawei.com; dmarc=none action=none header.from=caviumnetworks.com; Date: Wed, 11 May 2016 11:04:38 +0300 From: Yury Norov To: "Zhangjian (Bamvor)" CC: Arnd Bergmann , , Andrew Pinski , , , Hanjun Guo , , , , "jijun (D)" , , , , , , , , , , Andrew Pinski , , Subject: Re: [PATCH 20/25] arm64:ilp32: add sys_ilp32.c and a separate table (in entry.S) to use it Message-ID: <20160511075438.GA15628@yury-N73SV> References: <1459894127-17698-1-git-send-email-ynorov@caviumnetworks.com> <7091358.aJt1stteb5@wuerfel> <5731D68D.2090109@huawei.com> <4119683.coHZhzaE6c@wuerfel> <57329320.1000500@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <57329320.1000500@huawei.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-Originating-IP: [95.143.213.121] X-ClientProxiedBy: VI1PR06CA0030.eurprd06.prod.outlook.com (10.162.116.168) To SN1PR07MB2237.namprd07.prod.outlook.com (10.164.47.143) X-MS-Office365-Filtering-Correlation-Id: 82a87c80-7e1e-4960-084a-08d37972f1b5 X-Microsoft-Exchange-Diagnostics: 1;SN1PR07MB2237;2:75fgy3LtmDiY/KVD1+7SYVQlw9n2AmkCzr1HUfuJYSPWwRsxixndaNZdQkO+xVxseldKjLy8m5U/gRaV98VsVjP8tRzWFr5V3t7CBEsK6g/HQNuBa4RmvsWWl/o4a9ZPaewehn5M6JbgHWZu4EdCSMclzUHhbVhuivyoX4tx3Fc4h0kGsCisvkIcNCzjUg/T;3:FZ0hK2gPV3vTAKBUVFOzZ3bVjV4jQGAEn/SxE9O5f2or8D6cGP6QgZZVmuPh/FQ6h2GsM7kTp3iPC4EOe0ie9VG6InzYyfxaBOHhS2p+xIOT9F4jA/hPPDdPoNsWFw7Y;25:OX5UR/KRiPSDbpPfVGBRSTwQRep96Zw7peHZ0KtaFhOPyI6aBqRlCweYid3/fwzyLGDFgamuANPG4ZEQxIy7fooi21zfpB+y8tk7dBG/PI6mgxWAml/frTlRoz8sjIHqqFvVewXF0/qsQ0i3SqVfu5PAE6netzQ+M7vIXtf7uBpPUsUWxbBZ2dRBmAneRCKG4EESXTS5/2yHn1Ktys5Vb8CmM5WHpfHOMRXewIalBvr1hhjrX+hQWxyuCLm4n/d5b0V4YeBHbHF0F2vgzY4XufiMKWEBB40vMkC1E26A/TbM66rpHeEiBwI83w2J4gon1OF5q/U5MMv7z9kiEhhpou60pzRvAVDPZ9QY6qNdJiGmMaI9jWBK8HqseZ/YlMTyA3F+W5Gbq8cHnTP0mvL5SJnRIzEvC4fGV6rXCpMrRn/FFkQTJFd6OJ7ml3OS7G0d X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:SN1PR07MB2237; X-Microsoft-Exchange-Diagnostics: 1;SN1PR07MB2237;20:KsH+wxU8LzsZUVhxpGntBV6Q+HhfG4dlDjaKsL5YoJvpH5hd62UiZ71n42wxuaAxnfPMg1htYbrF0XpO9YRcpMHVeQhAly5Z8pPCvoyFEDIMufgqQDX0gP1hD8DWP8UbgdixemCA+eKokyT1QlbQvL8NUhvSMpBKyH0kvDK/GgRAdyoSdm/DMR4OkflGj4MHhZ7EOdiPY/6NlVK0xVkbbMWMhV9yhZZd+pcRYCt9kQJNfytwHN6oHLBLwFeQjBtP9+luqCqchs+GLL3OPeDNLge3B9wLiH5s1XBoBWaiTYArpEO5hhVZvtTwa/Zg/eNMkKXxSXAnitBzmwDhRM8u4bTkyRGjarm0TUdZPeW4PJNx+G5fOFHUAwKnJX6oJ0Sr6qz+SCNCz3ViRGxeWjcCalR16Jhp5k4TmIiJxuftrt0iWFmR+Rez5n9KOxnB6ZtV7VcQXC9lYad7OrcuF99EGWCKbCSPphc2NLPqoK8Itk8+OgrNKW2glBb0QNo4zwcBh2r6wynBz9MOTBAfiaFDBBmNwaJK0/AKqgwxjzAP/DzRW7D0h8fGMSRVaZv1GPj76INXr24fcT1N4gvFZ25Cmd47DryjKu2Ggl1D67nmOsE= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001);SRVR:SN1PR07MB2237;BCL:0;PCL:0;RULEID:;SRVR:SN1PR07MB2237; X-Microsoft-Exchange-Diagnostics: 1;SN1PR07MB2237;4:oHeiHLsajAAUdkxYb6FRr1E1Os/13IiBddLHMBRb7ZCfTlmhFz82rnzxHPLU22T0yLSA0Dz6cNV90QJd4Xo9TiRvc+uF96IiC+2FI9QMc5XSny7TOVFkPUWcEpp6/VLVtCDMHg7QciUOzs8nmUf5ycUXOwLK/PPbR7P86NKZvQbXuhf1EMuPLlhlXEDh4hCdXqRHy0wORGt7ljpPhWIVjHFBtUMBcAkrvgNlsV7tdlGxcWmjle/q5jLkfVLc51+i4xfIZfG/rq+rq/MDBbeLtqwciRwT/yzFsU10Mp0Dx4IX8bA8HISqna5jh6uM9q11ZIoE2slIeqreFSkD1VIXDW4fYhLtiY5y8UKnKF49j/cMxIWzNkb92G1fdHIYNt2W X-Forefront-PRVS: 0939529DE2 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6069001)(6009001)(24454002)(9686002)(2906002)(5008740100001)(93886004)(189998001)(97756001)(110136002)(46406003)(81166006)(50466002)(33716001)(4001350100001)(4326007)(6116002)(42186005)(19580405001)(1720100001)(19580395003)(1076002)(76506005)(23726003)(33656002)(54356999)(66066001)(76176999)(83506001)(50986999)(47776003)(586003)(3846002)(92566002)(5004730100002)(2950100001)(77096005)(15975445007);DIR:OUT;SFP:1101;SCL:1;SRVR:SN1PR07MB2237;H:localhost;FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;SN1PR07MB2237;23:MFqQj8uvkBftya4Ztmjix4yrV2kzyHEhHSIKwBaIL?= =?us-ascii?Q?tdCE+Uxfpoiv6TduT+EtYpJ+ytb8Z7l2diIjN2OFimDU3Omy+WyaBFs8oqJC?= =?us-ascii?Q?0qbGR6m8XZCeddCeDx38UKXrVnMhy4GbFaf5Yfgk18VWZUUEHlZe1dAS4IYF?= =?us-ascii?Q?9+UIo/Gan8NPgzJXi4ECr9UR/Eym/1Mek63zN8M1AEMWJexbWGtn85rdyGEk?= =?us-ascii?Q?nYDgmEUn+wgaxxP9YKSmFNrdUtCloyyNtsCz6/gCWw0sppzQR2UwNwUMtJD2?= =?us-ascii?Q?qBlrUijqcN1MyV2ExSl3ZasBhTQNVbJURIACWnv1mEpVZ7XtkCPRhp20M3MR?= =?us-ascii?Q?NuzacLEZsbP8m76IptzrrlX1FbcmBrkUZtndBzpxO04gi++T2Zp8PiaIc/Lz?= =?us-ascii?Q?OT6mw+GASbcaB0TFGvbITGNJ9hxteboffXr152Mz/HIH8Qjt0Qx9M8Ht4jkP?= =?us-ascii?Q?Yv4hWNTrGbGrn7R85x3P2gQL2nyejlSMwKLCFbJznDegXV9DSy4B75syFzg8?= =?us-ascii?Q?fGa3UPFxRSQWKhJENFV7C7EHYsZZ/9Cezf/dF7ISzBJhPxbK9f3Wep2d0vEZ?= =?us-ascii?Q?9KEob9H3Ine1m18C+8T+fCosSZKdLw6iOlM67uprNo538Rj1kv6nh1x9z9h2?= =?us-ascii?Q?wHPJHxD6/X5dFjtTHkyD3wuVWnAAXcno6ZhmiA6Tn8v+5+hLylOJpWzssTKi?= =?us-ascii?Q?5bm7y4L4PkWBXSLjf/dexCb9WdRZbDy3xDXnvjss4n9Ra8PVDbPBG9NL4qdi?= =?us-ascii?Q?v457Hb8uzYONyLkeuezo0fXGrWxvLaMfhcxa5jGGGgMlVEb7NuBwTdgp/ha1?= =?us-ascii?Q?Seyhl4701aXKV0pDZ1Fls1QUenGfzt00OfsOdNWb6wIDeFUunZU/oah17wxB?= =?us-ascii?Q?W3u5dqOmcXG2LZURea4PewR1lI3IQpM57bTm1rFm84divCopRetW2RQPfRcS?= =?us-ascii?Q?GInDfs/+hP+bVfrpiCueZeqG39mR7CIi1OrJBtDVxk+OIb+C8ftYXJsEJorh?= =?us-ascii?Q?g7RfuPllZ2yhbhI+z8CYsw/?= X-Microsoft-Exchange-Diagnostics: 1;SN1PR07MB2237;5:wxAuk4c1NN0RozOlqj5tUwcfhbVXuzYpJTA1UHvd/bJHiUhl7k3jNPT/yegilVab9+fUmaEyz0vEZb5cq4BplD7TpO0Do0F/0jSe9+YXfJS5GEs6z4VNExCYSOkvkmJBM4CUxzGuZX0PVmVOFZtzYA==;24:cGzTxnnG79pq6Pj8xn3HODnEPJoLU6aikbjWvWGexjso/WtuI/e2bYAu0iuyTTA7zQ0RzuN87ofZlo1epTz8C2BSMxQ8sk/LAsZy7WlAaUw=;7:VmUc5YFnh9Al9V6wxuB7UkUt0YKmd3TmlYPDg/A+TNz0va43Bg6thNHb77iLv2gOVwUZILjzn8AWCCQLxb5tFK7mlxWZpU5L0tgE5kH8KOCYZ+WUaxg5kMK9353NvjSawdMaJs5MDVOu8YChgn+SHnywlyhxL8ILj/UbGg9tunLZcrrtj5vAkS8/iGzpzVQx SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 May 2016 08:04:57.3558 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR07MB2237 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 11, 2016 at 10:04:16AM +0800, Zhangjian (Bamvor) wrote: [...] > >>Ok, I will test the ltp syscall test. > >>With this changes, the issue I mentioned should be fixed. But we still > >>use mmap2 syscall for ILP32 application when we pass the offset instead > >>of page offset. Is it correct? > > > >I don't remember. It's probably not important whether we have the shift > >in there, as long as it's independent of the actual kernel page size and > >user space and kernel agree on the calling conventions. > Well. I am ok with where to shift the pages size because we get the same > result. I was just thinking if we should get rid of the name of mmap2 in our > ILP32 porting. Actually, it is mmap but we name it as mmap2. User may confused > if they do not know the implementations. > This is what generic unistd.h does. If you want to change it, you'd change each arch that uses generic unistd.h. > Regards > > Bamvor > > > > > Arnd > > > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel