From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932220AbcEKJNs (ORCPT <rfc822;w@1wt.eu>);
	Wed, 11 May 2016 05:13:48 -0400
Received: from bombadil.infradead.org ([198.137.202.9]:34081 "EHLO
	bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S932102AbcEKJNn (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 11 May 2016 05:13:43 -0400
Date: Wed, 11 May 2016 11:13:33 +0200
From: Peter Zijlstra <peterz@infradead.org>
To: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Thomas Gleixner <tglx@linutronix.de>, x86@kernel.org,
        Borislav Petkov <bp@alien8.de>, Ingo Molnar <mingo@redhat.com>,
        linux-kernel@vger.kernel.org, vince@deater.net, eranian@google.com,
        Arnaldo Carvalho de Melo <acme@infradead.org>
Subject: Re: [PATCH 2/2] perf: Disable the event on a truncated AUX record
Message-ID: <20160511091333.GA3190@twins.programming.kicks-ass.net>
References: <1462886313-13660-1-git-send-email-alexander.shishkin@linux.intel.com>
 <1462886313-13660-3-git-send-email-alexander.shishkin@linux.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1462886313-13660-3-git-send-email-alexander.shishkin@linux.intel.com>
User-Agent: Mutt/1.5.21 (2012-12-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, May 10, 2016 at 04:18:33PM +0300, Alexander Shishkin wrote:
> When the PMU driver reports a truncated AUX record, it effectively means
> that there is no more usable room in the event's AUX buffer (even though
> there may still be some room, so that perf_aux_output_begin() doesn't take
> action). At this point the consumer still has to be woken up and the event
> has to be disabled, otherwise the event will just keep spinning between
> perf_aux_output_begin() and perf_aux_output_end() until its context gets
> unscheduled.
> 
> Again, for cpu-wide events this means never, so once in this condition,
> they will be forever losing data.
> 
> Fix this by disabling the event and waking up the consumer in case of a
> truncated AUX record.

> +	if (wakeup) {
> +		if (truncated)
> +			handle->event->pending_disable = 1;
> +		perf_output_wakeup(handle);
> +	}

Does the userspace tool know how to deal with this and re-enable it?