From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752378AbcEKMko (ORCPT ); Wed, 11 May 2016 08:40:44 -0400 Received: from mail-wm0-f68.google.com ([74.125.82.68]:35142 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751454AbcEKMkm (ORCPT ); Wed, 11 May 2016 08:40:42 -0400 Date: Wed, 11 May 2016 14:40:40 +0200 From: Michal Hocko To: Vlastimil Babka Cc: linux-mm@kvack.org, Andrew Morton , Joonsoo Kim , Rik van Riel , David Rientjes , Mel Gorman , Johannes Weiner , Tetsuo Handa , linux-kernel@vger.kernel.org, Linus Torvalds , Hugh Dickins Subject: Re: [RFC 01/13] mm, compaction: don't isolate PageWriteback pages in MIGRATE_SYNC_LIGHT mode Message-ID: <20160511124039.GL16677@dhcp22.suse.cz> References: <1462865763-22084-1-git-send-email-vbabka@suse.cz> <1462865763-22084-2-git-send-email-vbabka@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1462865763-22084-2-git-send-email-vbabka@suse.cz> User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue 10-05-16 09:35:51, Vlastimil Babka wrote: > From: Hugh Dickins > > At present MIGRATE_SYNC_LIGHT is allowing __isolate_lru_page() to > isolate a PageWriteback page, which __unmap_and_move() then rejects > with -EBUSY: of course the writeback might complete in between, but > that's not what we usually expect, so probably better not to isolate it. this makes a lot of sense regardless the rest of the series. I will have a look at the rest tomorrow more closely. > > Signed-off-by: Hugh Dickins > Signed-off-by: Vlastimil Babka Acked-by: Michal Hocko > --- > mm/compaction.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/compaction.c b/mm/compaction.c > index c72987603343..481004c73c90 100644 > --- a/mm/compaction.c > +++ b/mm/compaction.c > @@ -1146,7 +1146,7 @@ static isolate_migrate_t isolate_migratepages(struct zone *zone, > struct page *page; > const isolate_mode_t isolate_mode = > (sysctl_compact_unevictable_allowed ? ISOLATE_UNEVICTABLE : 0) | > - (cc->mode == MIGRATE_ASYNC ? ISOLATE_ASYNC_MIGRATE : 0); > + (cc->mode != MIGRATE_SYNC ? ISOLATE_ASYNC_MIGRATE : 0); > > /* > * Start at where we last stopped, or beginning of the zone as > -- > 2.8.2 -- Michal Hocko SUSE Labs