From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932817AbcEKOIx (ORCPT <rfc822;w@1wt.eu>);
	Wed, 11 May 2016 10:08:53 -0400
Received: from bombadil.infradead.org ([198.137.202.9]:46525 "EHLO
	bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S932613AbcEKOIw (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 11 May 2016 10:08:52 -0400
Date: Wed, 11 May 2016 16:08:43 +0200
From: Peter Zijlstra <peterz@infradead.org>
To: Andrey Ryabinin <aryabinin@virtuozzo.com>
Cc: Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
        "H. Peter Anvin" <hpa@zytor.com>, x86@kernel.org,
        Jim Cromie <jim.cromie@gmail.com>, Imre Palik <imrep@amazon.de>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf/x86: fix undefined shift on 32-bit kernels
Message-ID: <20160511140843.GG3192@twins.programming.kicks-ass.net>
References: <CAJfuBxz3-oqvB+KYrGKoQwiz88efs3bti=FJEKOAntUO7h71ew@mail.gmail.com>
 <1462974711-10037-1-git-send-email-aryabinin@virtuozzo.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1462974711-10037-1-git-send-email-aryabinin@virtuozzo.com>
User-Agent: Mutt/1.5.21 (2012-12-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, May 11, 2016 at 04:51:51PM +0300, Andrey Ryabinin wrote:
> Jim reported:
> 	UBSAN: Undefined behaviour in arch/x86/events/intel/core.c:3708:12
> 	shift exponent 35 is too large for 32-bit type 'long unsigned int'
> 
> The use of 'unsigned long' type obviously is not correct here, make it
> 'unsigned long long' instead.
> 
> Fixes: 2c33645d366d ("perf/x86: Honor the architectural performance monitoring version")
> Reported-by: Jim Cromie <jim.cromie@gmail.com>
> Signed-off-by: Andrey Ryabinin <aryabinin@virtuozzo.com>

Thanks!