From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752686AbcEKVHh (ORCPT ); Wed, 11 May 2016 17:07:37 -0400 Received: from nblzone-211-213.nblnetworks.fi ([83.145.211.213]:51096 "EHLO hillosipuli.retiisi.org.uk" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752500AbcEKVHg (ORCPT ); Wed, 11 May 2016 17:07:36 -0400 Date: Thu, 12 May 2016 00:07:32 +0300 From: Sakari Ailus To: Mauro Carvalho Chehab Cc: David R , Linux Media Mailing List , Linux Kernel Mailing List , gregkh@linuxfoundation.org, hverkuil@xs4all.nl Subject: Re: Patch: V4L stable versions 4.5.3 and 4.5.4 Message-ID: <20160511210731.GS26360@valkosipuli.retiisi.org.uk> References: <57337E39.40105@unsolicited.net> <57338272.4080908@unsolicited.net> <20160511173823.7d0dca7e@recife.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160511173823.7d0dca7e@recife.lan> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Mauro and David, On Wed, May 11, 2016 at 05:38:23PM -0300, Mauro Carvalho Chehab wrote: > Hi David, > > Em Wed, 11 May 2016 20:05:22 +0100 > David R escreveu: > > > On 11/05/16 19:47, David R wrote: > > > Hi > > > > > > Please consider applying the attached patch (or something like it) to > > > V4L2, and whatever is appropriate to the mainstream kernel. Without this > > > my media server crashes and burns at boot. > > > > > > See https://lkml.org/lkml/2016/5/7/88 for more details > > > > > > Thanks > > > David > > > > > I see the offending patch was reverted earlier today. My box is fine > > with my (more simple) alternative, but your call. > > Yes, I noticed the bug earlier today, while testing a DVB device. > As this affects 2 stable releases plus the upcoming Kernel 4.6, > I decided to just revert it for now, while we don't solve the > issue. > > Your patch looks good. So, eventually it will be merged on a new > version of this patch, after we test it properly. Indeed vb2_core_dqbuf() is called with pb == NULL in file I/O, which was unfortunately missed until now. The proposed fix looks good to me. -- Kind regards, Sakari Ailus e-mail: sakari.ailus@iki.fi XMPP: sailus@retiisi.org.uk