From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752539AbcELHbg (ORCPT <rfc822;w@1wt.eu>);
	Thu, 12 May 2016 03:31:36 -0400
Received: from verein.lst.de ([213.95.11.211]:48275 "EHLO newverein.lst.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751943AbcELHbf (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Thu, 12 May 2016 03:31:35 -0400
Date: Thu, 12 May 2016 09:31:33 +0200
From: Christoph Hellwig <hch@lst.de>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: "Dmitry V. Levin" <ldv@altlinux.org>, Ingo Molnar <mingo@redhat.com>,
        "H. Peter Anvin" <hpa@zytor.com>, x86@kernel.org,
        Christoph Hellwig <hch@lst.de>, LKML <linux-kernel@vger.kernel.org>,
        Milosz Tanski <milosz@adfin.com>, Al Viro <viro@zeniv.linux.org.uk>
Subject: Re: [PATCH] x86: use compat version for preadv2 and pwritev2
Message-ID: <20160512073133.GB3852@lst.de>
References: <20160511084817.GA29823@altlinux.org> <alpine.DEB.2.11.1605111212440.3540@nanos>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <alpine.DEB.2.11.1605111212440.3540@nanos>
User-Agent: Mutt/1.5.17 (2007-11-01)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, May 11, 2016 at 12:14:11PM +0200, Thomas Gleixner wrote:
> On Wed, 11 May 2016, Dmitry V. Levin wrote:
> > Similar to preadv and pwritev, preadv2 and pwritev2 need compat entries
> > in the 32-bit syscall table.
> 
> So this is 2016 and we added a syscalls which require compat support. What's
> wrong here?

Nothing.  It's and extension of readv/writev and uses struct iovec,
which is different for compat vs native.  We have efficient infrastructure
to deal with that in the kernel, while in userspace people would have
to copy around all the iovecs for every I/O, which would be a nightmare.