From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752285AbcELIi7 (ORCPT ); Thu, 12 May 2016 04:38:59 -0400 Received: from mx2.suse.de ([195.135.220.15]:34259 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751646AbcELIi5 (ORCPT ); Thu, 12 May 2016 04:38:57 -0400 Date: Thu, 12 May 2016 10:38:52 +0200 From: Jan Kara To: Vishal Verma Cc: linux-nvdimm@ml01.01.org, linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, xfs@oss.sgi.com, linux-ext4@vger.kernel.org, linux-mm@kvack.org, Ross Zwisler , Dan Williams , Dave Chinner , Jan Kara , Jens Axboe , Andrew Morton , linux-kernel@vger.kernel.org, Christoph Hellwig , Jeff Moyer , Boaz Harrosh Subject: Re: [PATCH v7 5/6] dax: for truncate/hole-punch, do zeroing through the driver if possible Message-ID: <20160512083852.GB10306@quack2.suse.cz> References: <1463000932-31680-1-git-send-email-vishal.l.verma@intel.com> <1463000932-31680-6-git-send-email-vishal.l.verma@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1463000932-31680-6-git-send-email-vishal.l.verma@intel.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed 11-05-16 15:08:51, Vishal Verma wrote: > In the truncate or hole-punch path in dax, we clear out sub-page ranges. > If these sub-page ranges are sector aligned and sized, we can do the > zeroing through the driver instead so that error-clearing is handled > automatically. > > For sub-sector ranges, we still have to rely on clear_pmem and have the > possibility of tripping over errors. > > Cc: Dan Williams > Cc: Ross Zwisler > Cc: Jeff Moyer > Cc: Christoph Hellwig > Cc: Dave Chinner > Cc: Jan Kara > Reviewed-by: Christoph Hellwig > Signed-off-by: Vishal Verma The patch looks good to me now. Feel free to add: Reviewed-by: Jan Kara Honza -- Jan Kara SUSE Labs, CR