From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752800AbcELNVb (ORCPT ); Thu, 12 May 2016 09:21:31 -0400 Received: from mail-wm0-f48.google.com ([74.125.82.48]:37202 "EHLO mail-wm0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752411AbcELNV2 (ORCPT ); Thu, 12 May 2016 09:21:28 -0400 Date: Thu, 12 May 2016 14:21:40 +0100 From: Lee Jones To: Keerthy Cc: broonie@kernel.org, lgirdwood@gmail.com, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, devicetree@vger.kernel.org, robh+dt@kernel.org, mark.rutland@arm.com Subject: Re: [PATCH v2 1/3] Documentation: mfd: LP873X: Add information for the mfd and regulator drivers Message-ID: <20160512132140.GC1433@dell.open.watershed.co.uk> References: <1462853079-10708-1-git-send-email-j-keerthy@ti.com> <1462853079-10708-2-git-send-email-j-keerthy@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1462853079-10708-2-git-send-email-j-keerthy@ti.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 10 May 2016, Keerthy wrote: > Add information for the mfd and regulator drivers. > > Signed-off-by: Keerthy > --- > Documentation/devicetree/bindings/mfd/lp873x.txt | 55 ++++++++++++++++++++++++ > 1 file changed, 55 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mfd/lp873x.txt > > diff --git a/Documentation/devicetree/bindings/mfd/lp873x.txt b/Documentation/devicetree/bindings/mfd/lp873x.txt > new file mode 100644 > index 0000000..3ef5ea0 > --- /dev/null > +++ b/Documentation/devicetree/bindings/mfd/lp873x.txt > @@ -0,0 +1,55 @@ > +TI LP3943 MFD driver > + > +Required properties: > + - compatible: "ti,lp8732", "ti,lp8733" > + - reg: I2C slave address. > + > +For the lp873x regulator properties please refer to: > +Documentation/devicetree/bindings/regulator/lp873x.txt This is a Linuxism. Use ../bindings/.. instead. > +Example: > + > +lp8733: lp8733@60 { lp8733 is not a device 'type'. What does it do? Looks like a 'pmic' to me. > + compatible = "ti,lp8733"; > + reg = <0x60>; > + > + regulators { > + lp8733_buck0: buck0 { > + regulator-name = "lp8733-buck0"; > + regulator-min-microvolt = <800000>; > + regulator-max-microvolt = <1400000>; > + regulator-min-microamp = <1500000>; > + regulator-max-microamp = <4000000>; > + regulator-ramp-delay = <10000>; > + regulator-always-on; > + regulator-boot-on; > + }; > + > + lp8733_buck1: buck1 { > + regulator-name = "lp8733-buck1"; > + regulator-min-microvolt = <800000>; > + regulator-max-microvolt = <1400000>; > + regulator-min-microamp = <1500000>; > + regulator-max-microamp = <4000000>; > + regulator-ramp-delay = <10000>; > + regulator-boot-on; > + regulator-always-on; > + }; > + > + lp8733_ldo0: ldo0 { > + regulator-name = "lp8733-ldo0"; > + regulator-min-microvolt = <800000>; > + regulator-max-microvolt = <3000000>; > + regulator-boot-on; > + regulator-always-on; > + }; > + > + lp8733_ldo1: ldo1 { > + regulator-name = "lp8733-ldo1"; > + regulator-min-microvolt = <800000>; > + regulator-max-microvolt = <3000000>; > + regulator-always-on; > + regulator-boot-on; > + }; > + }; > +}; I'm failing to see how this is an MFD? -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog