From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752921AbcELSnO (ORCPT ); Thu, 12 May 2016 14:43:14 -0400 Received: from 216-12-86-13.cv.mvl.ntelos.net ([216.12.86.13]:58022 "EHLO brightrain.aerifal.cx" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752071AbcELSnM (ORCPT ); Thu, 12 May 2016 14:43:12 -0400 Date: Thu, 12 May 2016 14:38:22 -0400 From: Rich Felker To: Kefeng Wang Cc: robh+dt@kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, arnd@arndb.de, shawnguo@kernel.org, catalin.marinas@arm.com, grant.likely@linaro.org, olof@lixom.net, linux@arm.linux.org.uk, yamada.masahiro@socionext.com, guohanjun@huawei.com, Yoshinori Sato Subject: Re: [PATCH v4 10/18] sh: Remove unnecessary of_platform_populate with default match table Message-ID: <20160512183822.GL21636@brightrain.aerifal.cx> References: <1463054775-18170-1-git-send-email-wangkefeng.wang@huawei.com> <1463054775-18170-11-git-send-email-wangkefeng.wang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1463054775-18170-11-git-send-email-wangkefeng.wang@huawei.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 12, 2016 at 08:06:07PM +0800, Kefeng Wang wrote: > After patch "of/platform: Add common method to populate default bus", > it is possible for arch code to remove unnecessary callers about the > of_platform_populate with default match table. s/about the/of/ ? > Cc: Yoshinori Sato > Cc: Rich Felker > Signed-off-by: Kefeng Wang > --- > arch/sh/boards/of-generic.c | 14 -------------- > 1 file changed, 14 deletions(-) > > diff --git a/arch/sh/boards/of-generic.c b/arch/sh/boards/of-generic.c > index b4d4313..911ffb9 100644 > --- a/arch/sh/boards/of-generic.c > +++ b/arch/sh/boards/of-generic.c > @@ -9,7 +9,6 @@ > */ > > #include > -#include > #include > #include > #include > @@ -179,16 +178,3 @@ void __init arch_init_clk_ops(struct sh_clk_ops **ops, int idx) > void __init plat_irq_setup(void) > { > } > - > -static int __init sh_of_device_init(void) > -{ > - pr_info("SH generic board support: populating platform devices\n"); > - if (of_have_populated_dt()) { > - of_platform_populate(NULL, of_default_bus_match_table, > - NULL, NULL); > - } else { > - pr_crit("Device tree not populated\n"); > - } > - return 0; > -} > -arch_initcall_sync(sh_of_device_init); > -- > 1.7.12.4 I have not tested this, but as long as the new arch-generic code takes place at the same point in the init sequence (arch_initcall_sync), as it seems to, I don't expect any sh-specific breakage. In general I'm happy to see this kind of change. Rich