From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753033AbcEMK7p (ORCPT <rfc822;w@1wt.eu>);
	Fri, 13 May 2016 06:59:45 -0400
Received: from mezzanine.sirena.org.uk ([106.187.55.193]:50610 "EHLO
	mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752960AbcEMK7m (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 13 May 2016 06:59:42 -0400
Date: Fri, 13 May 2016 11:58:52 +0100
From: Mark Brown <broonie@kernel.org>
To: Peter Rosin <peda@axentia.se>
Cc: linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
        Pawel Moll <pawel.moll@arm.com>, Mark Rutland <mark.rutland@arm.com>,
        Ian Campbell <ijc+devicetree@hellion.org.uk>,
        Kumar Gala <galak@codeaurora.org>, Liam Girdwood <lgirdwood@gmail.com>,
        Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
        Misbah Ullah Khan <Misbahk@danlawinc.com>, alsa-devel@alsa-project.org,
        devicetree@vger.kernel.org
Message-ID: <20160513105852.GC22038@sirena.org.uk>
References: <1463124333-9489-1-git-send-email-peda@axentia.se>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="xo44VMWPx7vlQ2+2"
Content-Disposition: inline
In-Reply-To: <1463124333-9489-1-git-send-email-peda@axentia.se>
X-Cookie: Whistler's mother is off her rocker.
User-Agent: Mutt/1.6.0 (2016-04-01)
X-SA-Exim-Connect-IP: 188.29.165.172
X-SA-Exim-Mail-From: broonie@sirena.org.uk
Subject: Re: [PATCH v3] ASoC: MAX9860: new driver
X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000)
X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


--xo44VMWPx7vlQ2+2
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Fri, May 13, 2016 at 09:25:33AM +0200, Peter Rosin wrote:

> +static int max9860_dai_startup(struct snd_pcm_substream *substream,
> +			       struct snd_soc_dai *dai)
> +{
> +	struct snd_soc_codec *codec = dai->codec;
> +	struct max9860_priv *max9860 = snd_soc_codec_get_drvdata(codec);
> +
> +	switch (max9860->fmt & SND_SOC_DAIFMT_MASTER_MASK) {
> +	case SND_SOC_DAIFMT_CBM_CFM:
> +	case SND_SOC_DAIFMT_CBS_CFS:
> +		return 0;
> +
> +	default:
> +		return -EINVAL;
> +	}
> +}

This isn't the place to enforce restrictions on DAI format, do it in
set_dai_fmt().

Otherwise this looks good.

--xo44VMWPx7vlQ2+2
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEcBAEBCAAGBQJXNbNqAAoJECTWi3JdVIfQUksH/iRwuGnoUek3FCic4AgeNTZw
FvcpVNAav8wSi0k9eCAesSHaUS7EHJGe195Ts0O29kkFclFVFFagShuRv4YQK9L4
BeHp4dtYvytwXFhcPJvtskS3ATVhmLAc3CP6ETkCK9tRDaKcufEU2RjIdVJVdEIp
x3R6Ykxw21aiBYItHk4sq4vuO5cUvGjx5/WQPGrPIfejjHwEBTL/QDKvPbSnaMvn
wtPmJd3nBM5nQ9WwWMlNVdPx5saU0CuVc4ZumwUBpTOIVE5gGgYbo/7WjPaPb19d
gBbOdNjOQcLd5rncz3/3RExOOzAWzByIiXQbHCw5ajCCgCv6VBazF71t3LsYklU=
=4uVn
-----END PGP SIGNATURE-----

--xo44VMWPx7vlQ2+2--