From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752751AbcEMLu1 (ORCPT ); Fri, 13 May 2016 07:50:27 -0400 Received: from sauhun.de ([89.238.76.85]:53621 "EHLO pokefinder.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750907AbcEMLu0 (ORCPT ); Fri, 13 May 2016 07:50:26 -0400 Date: Fri, 13 May 2016 13:50:21 +0200 From: Wolfram Sang To: Sricharan R Cc: devicetree@vger.kernel.org, architt@codeaurora.org, linux-arm-msm@vger.kernel.org, ntelkar@codeaurora.org, galak@codeaurora.org, linux-kernel@vger.kernel.org, andy.gross@linaro.org, linux-i2c@vger.kernel.org, iivanov@mm-sol.com, agross@codeaurora.org, dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org, nkaje@codeaurora.org Subject: Re: [PATCH V2 2/2] drivers: i2c: qup: Fix error handling Message-ID: <20160513115021.GK1778@katana> References: <1462534274-28925-1-git-send-email-sricharan@codeaurora.org> <1462534274-28925-3-git-send-email-sricharan@codeaurora.org> <20160513114823.GJ1778@katana> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="45wMVEkw4XUbiYON" Content-Disposition: inline In-Reply-To: <20160513114823.GJ1778@katana> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --45wMVEkw4XUbiYON Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, May 13, 2016 at 01:48:23PM +0200, Wolfram Sang wrote: > On Fri, May 06, 2016 at 05:01:14PM +0530, Sricharan R wrote: > > Among the bus errors reported from the QUP_MASTER_STATUS register > > only NACK is considered and transfer gets suspended, while > > other errors are ignored. Correct this and suspend the transfer > > for other errors as well. This avoids unnessecary 'timeouts' which > > happens when waiting for events that would never happen when there > > is already an error condition on the bus. > >=20 > > Signed-off-by: Sricharan R > > Reviewed-by: Andy Gross >=20 > Please check Documentation/i2c/fault-codes for proper fault codes. And while we are here: NACK is not an error but a valid response. Can you remove the dev_err related to that? Otherwise tools like i2cdetect will probably flood your log. --45wMVEkw4XUbiYON Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJXNb99AAoJEBQN5MwUoCm2pNoQAKOgdymmdFmQxQ8QxAqoxj1G uMdMDfVS563kCoqBBKjR7wxbWXcXaVNZ0WUNf5G5St5MmsxRfjquxBm+xmW5lx7D 3K+5x+Jgry1jGZ7QO5664CgksZJjrZbot1ZsW0vbTKfjaN6HCVawGjBrwpllyQmB wRkt3hhORdPBAICPdins6Am0mCoqAUAuRf+dj1pRoWbdQE6enYrcA3Kkf0SbGzIv 5j+lucE1maj2XhTZzfsqb/rMbbJg9vmQaw4xK8LtH7k7VCRHbK0/Bm8pd4niSSYO i3LwVogMDoUkMxe0Seirshqd9jPeZpVczPJqpcHrUqPl+ijSULClX6zdxtQeib1/ 4D9F80NGJ6x2g7rgCRT8sv/PxCipM8+JJbkYfxxutixnoiPhwKy2StfeUDBkxvat kVFJkfaolxrxQ2Mjo83hnneNBRkRh9giRuCh9VLmNfaZSbQDdHXopZN174HKn9uT bjF4f0jImWqWdqd2v5+xply/Yb9qrXR5Lh/vZwqVpp0YcerQifxccQ6/K1RhBZ7S R92tItR/iWoEAFm5gAWJ7w8+aSNjlD3SCjqoYmefjshH6xNHvv1+UUCPWH9/T2qN Ey4/FCsauanzGVxn59qHaouytZwEB2RaMjBYgK9tYwmucLh8FOU+Or2wVQWOEpTz 11JlQbV8vspCtw9sUeNT =l9K9 -----END PGP SIGNATURE----- --45wMVEkw4XUbiYON--