From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753312AbcEMOdy (ORCPT ); Fri, 13 May 2016 10:33:54 -0400 Received: from mga11.intel.com ([192.55.52.93]:41945 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751917AbcEMOdw (ORCPT ); Fri, 13 May 2016 10:33:52 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,614,1455004800"; d="scan'208";a="805604960" Date: Fri, 13 May 2016 10:33:47 -0400 From: Dennis Dalessandro To: Jason Gunthorpe Cc: Doug Ledford , Mike Marciniszyn , linux-rdma@vger.kernel.org, Mitko Haralanov , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Ira Weiny Subject: Re: [PATCH v2 3/5] IB/hfi1: Add ioctl() interface for user commands Message-ID: <20160513143346.GA6665@phlsvsds.ph.intel.com> References: <20160512171115.6198.77458.stgit@scvm10.sc.intel.com> <20160512171846.6198.31415.stgit@scvm10.sc.intel.com> <20160512174332.GB13553@obsidianresearch.com> <20160512192726.GB15146@phlsvsds.ph.intel.com> <20160512194006.GA6364@obsidianresearch.com> <20160512212821.GC6545@obsidianresearch.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20160512212821.GC6545@obsidianresearch.com> User-Agent: Mutt/1.4.2.2i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 12, 2016 at 03:28:21PM -0600, Jason Gunthorpe wrote: >On Thu, May 12, 2016 at 03:48:16PM -0400, Doug Ledford wrote: >> were going to rip out the EEPROM code. In any case, the best fix would >> be to rebase the two series that are remaining and move any "rip out >> things like eeprom support" patches to prior to the ioctl patches and >> make it so that they rip out the write interface version of it instead, >> and then squash a second copy of the ioctl removal into this patch. > >Yes, this would look best The end result will end up being the exact same code so I don't have a problem doing that. Perhaps it would be better if I just combine the two patch sets into one series? I still need to look more into the kobj stuff about the cdev, if needed I'll add a patch for that as well. -Denny