From: Andrew Lunn <andrew@lunn.ch>
To: Harini Katakam <harini.katakam@xilinx.com>
Cc: nicolas.ferre@atmel.com, davem@davemloft.net, robh+dt@kernel.org,
pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
harinikatakamlinux@gmail.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
harinik@xilinx.com, punnaia@xilinx.com, michals@xilinx.com
Subject: Re: [RFC PATCH 2/2] Documentation: devictree: Add macb mdio bindings
Date: Fri, 13 May 2016 19:43:00 +0200 [thread overview]
Message-ID: <20160513174300.GB7600@lunn.ch> (raw)
In-Reply-To: <1463131568-36948-2-git-send-email-harinik@xilinx.com>
Hi Harini
Is this backward compatible? Will devices using the old binding still
work?
/* Disable RX and TX (XXX: Should we halt the transmission
* more gracefully?)
*/
- macb_writel(bp, NCR, 0);
+ ctrl = macb_readl(bp, NCR);
+ ctrl &= ~(MACB_BIT(RE) | MACB_BIT(TE));
+ macb_writel(bp, NCR, ctrl);
/* Clear the stats registers (XXX: Update stats first?) */
- macb_writel(bp, NCR, MACB_BIT(CLRSTAT));
+ ctrl |= MACB_BIT(CLRSTAT);
+ macb_writel(bp, NCR, ctrl);
/* Clear all status flags */
macb_writel(bp, TSR, -1);
It is not clear to me what this part has to do with MDIO.
Andrew
next prev parent reply other threads:[~2016-05-13 17:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-13 9:26 [RFC PATCH 1/2] net: macb: Add MDIO driver for accessing multiple PHY devices Harini Katakam
2016-05-13 9:26 ` [RFC PATCH 2/2] Documentation: devictree: Add macb mdio bindings Harini Katakam
2016-05-13 17:36 ` Andrew Lunn
2016-05-13 17:43 ` Andrew Lunn [this message]
2016-05-14 2:50 ` Harini Katakam
2016-11-28 9:49 Harini Katakam
2016-12-03 21:35 ` Rob Herring
2016-12-03 22:40 ` Florian Fainelli
2016-12-05 3:03 ` Harini Katakam
2016-12-05 2:55 ` Harini Katakam
2016-12-05 10:23 ` Nicolas Ferre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160513174300.GB7600@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=harini.katakam@xilinx.com \
--cc=harinik@xilinx.com \
--cc=harinikatakamlinux@gmail.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=michals@xilinx.com \
--cc=netdev@vger.kernel.org \
--cc=nicolas.ferre@atmel.com \
--cc=pawel.moll@arm.com \
--cc=punnaia@xilinx.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®