From: Francois Romieu <romieu@fr.zoreil.com>
To: Paul Menzel <paulepanter@users.sourceforge.net>
Cc: Realtek linux nic maintainers <nic_swsd@realtek.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Stanislaw Gruszka <sgruszka@redhat.com>,
David Miller <davem@davemloft.net>, Chunhao Lin <hau@realtek.com>
Subject: Re: r8169: Unconditionally disabling ASPM
Date: Sun, 15 May 2016 20:42:01 +0200 [thread overview]
Message-ID: <20160515184201.GA23445@electric-eye.fr.zoreil.com> (raw)
In-Reply-To: <1463330971.6071.35.camel@users.sourceforge.net>
Paul Menzel <paulepanter@users.sourceforge.net> :
[...]
> As over five years have passed now, do you think that is still needed?
> I wonder why no module parameter was added back then, where users could
> enable ASPM if it works on their systems? Because there is no such
> situation and it always fails?
It was enabled again (d64ec841517a25f6d468bde9f67e5b4cffdc67c7) then
disabled (4521e1a94279ce610d3f9b7945c17d581f804242). It's closer
to 3.5 years :o)
Module parameters are frowned upon.
Lin, is there some interest in selectively [*] enabling (or disabling)
ASPM support in the r8169 driver or will it be unreliable ?
[*] Based on DMI information for instance.
--
Ueimor
prev parent reply other threads:[~2016-05-15 18:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-15 16:49 Paul Menzel
2016-05-15 18:42 ` Francois Romieu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160515184201.GA23445@electric-eye.fr.zoreil.com \
--to=romieu@fr.zoreil.com \
--cc=davem@davemloft.net \
--cc=hau@realtek.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
--cc=paulepanter@users.sourceforge.net \
--cc=sgruszka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®