From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754572AbcEPSBL (ORCPT ); Mon, 16 May 2016 14:01:11 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:37138 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753854AbcEPSBJ (ORCPT ); Mon, 16 May 2016 14:01:09 -0400 Date: Mon, 16 May 2016 14:01:07 -0400 (EDT) Message-Id: <20160516.140107.648493980838894656.davem@davemloft.net> To: falakreyaz@gmail.com Cc: arvid.brodin@alten.se, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net/hsr: Use setup_timer and mod_timer. From: David Miller In-Reply-To: <1463321265-11577-1-git-send-email-falakreyaz@gmail.com> References: <1463321265-11577-1-git-send-email-falakreyaz@gmail.com> X-Mailer: Mew version 6.6 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 16 May 2016 11:01:08 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Muhammad Falak R Wani Date: Sun, 15 May 2016 19:37:44 +0530 > The function setup_timer combines the initialization of a timer with the > initialization of the timer's function and data fields. The mulitiline > code for timer initialization is now replaced with function setup_timer. > > Also, quoting the mod_timer() function comment: > -> mod_timer() is a more efficient way to update the expire field of an > active timer (if the timer is inactive it will be activated). > > Use setup_timer() and mod_timer() to setup and arm a timer, making the > code compact and aid readablity. > > Signed-off-by: Muhammad Falak R Wani Applied.