From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753817AbcEPL2L (ORCPT ); Mon, 16 May 2016 07:28:11 -0400 Received: from sci-ig4.spreadtrum.com ([114.30.40.213]:34224 "EHLO TPSQR01.spreadtrum.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1751895AbcEPL2J convert rfc822-to-8bit (ORCPT ); Mon, 16 May 2016 07:28:09 -0400 X-Greylist: delayed 1216 seconds by postgrey-1.27 at vger.kernel.org; Mon, 16 May 2016 07:28:09 EDT From: "Pankaj Gupta (Pankaj Gupta)" To: "Rafael J. Wysocki" , Viresh Kumar CC: "linux-pm@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "Saravana Kannan" , Yinghai Lu Subject: [PATCH] driver: cpufreq: simplified goto out in cpufreq_register_driver Thread-Topic: [PATCH] driver: cpufreq: simplified goto out in cpufreq_register_driver Thread-Index: AQHRr2Mdb6CZnGDWREyE2PXw+z0fCg== Date: Mon, 16 May 2016 11:07:19 +0000 Message-ID: <20160516110718.GA5005@pankajguptaubtnb.spreadtrum.com> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.8.1.75] Content-Type: text/plain; charset="us-ascii" Content-ID: <18087D16B0B5D04CB9ED09BFCBC51869@spreadtrum.com> Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-MAIL: SHSQR01.spreadtrum.com u4GB7Jsc028237 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org simplified goto out in cpufreq_register_driver for increasing code readability Signed-off-by: Pankaj Gupta Signed-off-by: Sanjeev Yadav --- diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c index b87596b..0bc23f6 100644 --- a/drivers/cpufreq/cpufreq.c +++ b/drivers/cpufreq/cpufreq.c @@ -2370,10 +2370,7 @@ int cpufreq_register_driver(struct cpufreq_driver *driver_data) register_hotcpu_notifier(&cpufreq_cpu_notifier); pr_debug("driver %s up and running\n", driver_data->name); - -out: - put_online_cpus(); - return ret; + goto out; err_if_unreg: subsys_interface_unregister(&cpufreq_interface); @@ -2383,7 +2380,9 @@ err_null_driver: write_lock_irqsave(&cpufreq_driver_lock, flags); cpufreq_driver = NULL; write_unlock_irqrestore(&cpufreq_driver_lock, flags); - goto out; +out: + put_online_cpus(); + return ret; } EXPORT_SYMBOL_GPL(cpufreq_register_driver); ---