From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753773AbcEPLK0 (ORCPT ); Mon, 16 May 2016 07:10:26 -0400 Received: from mail-pa0-f51.google.com ([209.85.220.51]:36383 "EHLO mail-pa0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753645AbcEPLKX (ORCPT ); Mon, 16 May 2016 07:10:23 -0400 Date: Mon, 16 May 2016 16:40:19 +0530 From: Viresh Kumar To: "Pankaj Gupta (Pankaj Gupta)" Cc: "Rafael J. Wysocki" , "linux-pm@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Saravana Kannan , Yinghai Lu Subject: Re: [PATCH] driver: cpufreq: simplified goto out in cpufreq_register_driver Message-ID: <20160516111019.GC2832@vireshk-i7> References: <20160516110718.GA5005@pankajguptaubtnb.spreadtrum.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160516110718.GA5005@pankajguptaubtnb.spreadtrum.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 16-05-16, 11:07, Pankaj Gupta (Pankaj Gupta) wrote: > simplified goto out in cpufreq_register_driver for increasing > code readability > > Signed-off-by: Pankaj Gupta > Signed-off-by: Sanjeev Yadav > --- > diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c > index b87596b..0bc23f6 100644 > --- a/drivers/cpufreq/cpufreq.c > +++ b/drivers/cpufreq/cpufreq.c > @@ -2370,10 +2370,7 @@ int cpufreq_register_driver(struct cpufreq_driver *driver_data) > > register_hotcpu_notifier(&cpufreq_cpu_notifier); > pr_debug("driver %s up and running\n", driver_data->name); > - > -out: > - put_online_cpus(); > - return ret; > + goto out; > > err_if_unreg: > subsys_interface_unregister(&cpufreq_interface); > @@ -2383,7 +2380,9 @@ err_null_driver: > write_lock_irqsave(&cpufreq_driver_lock, flags); > cpufreq_driver = NULL; > write_unlock_irqrestore(&cpufreq_driver_lock, flags); > - goto out; > +out: > + put_online_cpus(); > + return ret; > } > EXPORT_SYMBOL_GPL(cpufreq_register_driver); Acked-by: Viresh Kumar -- viresh