From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754612AbcEPTYT (ORCPT ); Mon, 16 May 2016 15:24:19 -0400 Received: from smtprelay0130.hostedemail.com ([216.40.44.130]:54653 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754574AbcEPTYK (ORCPT ); Mon, 16 May 2016 15:24:10 -0400 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1538:1593:1594:1711:1714:1730:1747:1777:1792:2393:2553:2559:2562:2861:3138:3139:3140:3141:3142:3167:3351:3622:3865:3866:3867:3868:3870:3871:3872:3874:4250:5007:6119:6261:7875:7903:10004:10400:10848:10967:11026:11232:11658:11914:12438:12517:12519:12740:13069:13311:13357:13439:14181:14659:21080:21434:30054:30056:30070:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: crush38_5cd9d5b9b3e5b X-Filterd-Recvd-Size: 1929 Date: Mon, 16 May 2016 15:23:56 -0400 From: Steven Rostedt To: Borislav Petkov Cc: Namhyung Kim , Masami Hiramatsu , LKML , Ingo Molnar , x86@kernel.org, "H.J. Lu" Subject: Re: [PATCH] ftrace/x86: Fix function graph tracer reset path Message-ID: <20160516152356.149663c8@gandalf.local.home> In-Reply-To: <20160516191918.GC16265@pd.tnic> References: <1463147623-2575-1-git-send-email-namhyung@kernel.org> <20160515094141.0cff3ee44f1f0fa101b98b02@kernel.org> <20160515130652.GA7745@danjae.aot.lge.com> <20160516175614.53e0ceed3ec0880526fa1799@kernel.org> <20160516123250.GA16239@danjae.aot.lge.com> <20160516095833.08478147@gandalf.local.home> <20160516142453.GB16239@danjae.aot.lge.com> <20160516190359.GB16265@pd.tnic> <20160516151357.73fca76a@gandalf.local.home> <20160516191918.GC16265@pd.tnic> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 16 May 2016 21:19:18 +0200 Borislav Petkov wrote: > Btw, arch_static_branch_jump() spells that 5-byte JMP too and not until > too long ago we had it in static_cpu_has()... Those are "special" too. If we can get the compiler to do the Right Thing (TM) then we should let it. > > I guess after spending some time with the kernel, one can't really > differentiate hacks from proper design anymore. :-P > That's because a quality of a kernel is determined by the maintainability of all its hacks, not lack of them. -- Steve