From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754559AbcEPQmG (ORCPT ); Mon, 16 May 2016 12:42:06 -0400 Received: from mail.kernel.org ([198.145.29.136]:47717 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754506AbcEPQmB (ORCPT ); Mon, 16 May 2016 12:42:01 -0400 Date: Mon, 16 May 2016 11:41:56 -0500 From: Rob Herring To: Hans de Goede Cc: Mark Brown , Liam Girdwood , Maxime Ripard , Chen-Yu Tsai , linux-arm-kernel@lists.infradead.org, devicetree , Linux Kernel Mailing List , linux-sunxi@googlegroups.com Subject: Re: [PATCH] regulator: axp20x: Add support for the (external) drivebus regulator Message-ID: <20160516164156.GA24677@rob-hp-laptop> References: <1463248545-16543-1-git-send-email-hdegoede@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1463248545-16543-1-git-send-email-hdegoede@redhat.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, May 14, 2016 at 07:55:45PM +0200, Hans de Goede wrote: > The axp20x pmics have 2 power inputs, one called ACIN which is intended > for to be supplied via a powerbarrel on the board and one called VBUS > which is intended to be supplied via an otg connector. > > In the VBUS case the pmic needs to know if the board is supplying power > to the otg connector, because then it should not take any power from > its VBUS pin. The axp209 pmic has a N_VBUSEN input pin via which the > board can signal to the pmic whether the board is supplying power to the > otg connector or not. > > On the axp221/axp223 this pin can alternatively be used as an output > which controls an external regulator which (optionally) supplies > power to the otg connector from the board. When the pin is used as > output it is called DRIVEBUS in the datasheet. > > This commit adds support for the DRIVEBUS pin as an extra pmic > controlled regulator. Since this is optional a new x-powers,drivebus dt > property is added. When this is present the misc-control register is > written to change the N_VBUSEN input pin to DRIVEBUS output pin mode and > the extra drivebus regulator is registered with the regulator subsystem. > > Signed-off-by: Hans de Goede > --- > Documentation/devicetree/bindings/mfd/axp20x.txt | 5 ++++ > drivers/regulator/axp20x-regulator.c | 30 ++++++++++++++++++++++++ > 2 files changed, 35 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mfd/axp20x.txt b/Documentation/devicetree/bindings/mfd/axp20x.txt > index d20b103..7a88479 100644 > --- a/Documentation/devicetree/bindings/mfd/axp20x.txt > +++ b/Documentation/devicetree/bindings/mfd/axp20x.txt > @@ -22,6 +22,11 @@ Optional properties: > AXP152/20X: range: 750-1875, Default: 1.5 MHz > AXP22X/80X: range: 1800-4050, Default: 3 MHz > > +- x-powers,drivebus: axp221 / axp223 only boolean, set this when the N_VBUSEN x-powers,drive-vbus-en > + pin is used as an output pin to control an external regulator > + to drive the OTG VBus, rather then as an input pin which > + signals whether the board is driving OTG VBus or not. > + > - -supply: a phandle to the regulator supply node. May be omitted if > inputs are unregulated, such as using the IPSOUT output > from the PMIC.