From: Josh Poimboeuf <jpoimboe@redhat.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] objtool: cope with pre-4.5 gcc (and non-gcc)
Date: Mon, 16 May 2016 16:40:38 -0500 [thread overview]
Message-ID: <20160516214038.6od5wps35fxareys@treble> (raw)
In-Reply-To: <57358FDA02000078000EB174@prv-mh.provo.novell.com>
On Fri, May 13, 2016 at 12:27:06AM -0600, Jan Beulich wrote:
> The kernel's unreachable() translates to __builtin_unreachable() only
> for gcc 4.5 and newer, and else expands to an infinite loop. Avoid
> "function has unreachable instruction" warnings for this case by
> inspecting the instructions immediately following the UD2. This cuts
> down the number of files getting such warnings by about 99% for me.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Thanks for the patch. I'm wondering if we can detect this situation
more precisely, maybe by adding some kind of annotation to the
unreachable() macro. Will need to think about it a little more...
--
Josh
prev parent reply other threads:[~2016-05-16 21:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-13 6:27 Jan Beulich
2016-05-16 21:40 ` Josh Poimboeuf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160516214038.6od5wps35fxareys@treble \
--to=jpoimboe@redhat.com \
--cc=JBeulich@suse.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®