From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752004AbcEPWak (ORCPT ); Mon, 16 May 2016 18:30:40 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:29772 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751368AbcEPWah (ORCPT ); Mon, 16 May 2016 18:30:37 -0400 X-Greylist: delayed 655 seconds by postgrey-1.27 at vger.kernel.org; Mon, 16 May 2016 18:30:37 EDT Message-Id: <201605162219.u4GMItOK024273@mx0b-001b2d01.pphosted.com> X-IBM-Helo: d24dlp02.br.ibm.com X-IBM-MailFrom: gpiccoli@linux.vnet.ibm.com X-IBM-RcptTo: linux-kernel@vger.kernel.org Subject: Re: [PATCH] Use MICRO UINT_MAX instead of actual value To: Minfei Huang References: <1461554009-1695-1-git-send-email-mnghuan@gmail.com> <20160430101303.GB27909@huangminfeis-MacBook-Pro.local> Cc: keith.busch@intel.com, axboe@fb.com, linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org From: "Guilherme G. Piccoli" Date: Mon, 16 May 2016 19:19:34 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <20160430101303.GB27909@huangminfeis-MacBook-Pro.local> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16051622-0024-0000-0000-000000C67D77 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16051622-0025-0000-0000-000015090ACC X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-05-16_09:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_spam_policy_notspam policy=outbound_spam_policy score=0 spamscore=0 suspectscore=9 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1604210000 definitions=main-1605160283 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/30/2016 07:13 AM, Minfei Huang wrote: > Ping. > > Any comment is appreciate. Hi Minfei, I guess a good idea would be to resend the patch with the typo fixed, as a v2 patch. What do you think? Cheers, Guilherme > > Thanks > Minfei > > On 04/25/16 at 11:13P, Minfei Huang wrote: >> It's more elegant to use MICRO UINT_MAX to represent the max value of >> type unsigned int. So replace the actual value by using this MICRO. >> >> Signed-off-by: Minfei Huang >> --- >> drivers/nvme/host/core.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c >> index 643f457..2c0bb13 100644 >> --- a/drivers/nvme/host/core.c >> +++ b/drivers/nvme/host/core.c >> @@ -597,7 +597,7 @@ static void nvme_config_discard(struct nvme_ns *ns) >> >> ns->queue->limits.discard_alignment = logical_block_size; >> ns->queue->limits.discard_granularity = logical_block_size; >> - blk_queue_max_discard_sectors(ns->queue, 0xffffffff); >> + blk_queue_max_discard_sectors(ns->queue, UINT_MAX); >> queue_flag_set_unlocked(QUEUE_FLAG_DISCARD, ns->queue); >> } >> >> -- >> 2.6.3 >> > > _______________________________________________ > Linux-nvme mailing list > Linux-nvme@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-nvme >