From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756307AbcEQQbZ (ORCPT ); Tue, 17 May 2016 12:31:25 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:48181 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756274AbcEQQbY (ORCPT ); Tue, 17 May 2016 12:31:24 -0400 Date: Tue, 17 May 2016 12:31:21 -0400 (EDT) Message-Id: <20160517.123121.1984109840595169844.davem@davemloft.net> To: harvey.hunt@imgtec.com Cc: marcel@ziswiler.com, robert.jarzmik@free.fr, Baohua.Song@csr.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 net] drivers: net: Don't print unpopulated net_device name From: David Miller In-Reply-To: <1463492007-12013-1-git-send-email-harvey.hunt@imgtec.com> References: <1463492007-12013-1-git-send-email-harvey.hunt@imgtec.com> X-Mailer: Mew version 6.6 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 17 May 2016 09:31:23 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Harvey Hunt Date: Tue, 17 May 2016 14:33:27 +0100 > For ethernet devices, net_device.name will be eth%d before > register_netdev() is called. Don't print the net_device name until > the format string is replaced. > > Signed-off-by: Harvey Hunt > Cc: Marcel Ziswiler > Cc: Robert Jarzmik > Cc: Barry Song > Cc: netdev@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > --- > v1 -> v2: > - Replace ifconfig with ip > - Delay printk until the netdev name is known Yeah this looks a lot better, applied, thanks!