From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755843AbcEQJ6Y (ORCPT ); Tue, 17 May 2016 05:58:24 -0400 Received: from eu-smtp-delivery-143.mimecast.com ([146.101.78.143]:41513 "EHLO eu-smtp-delivery-143.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752408AbcEQJ6V convert rfc822-to-8bit (ORCPT ); Tue, 17 May 2016 05:58:21 -0400 Date: Tue, 17 May 2016 17:57:33 +0800 From: Huang Shijie To: David Long CC: Catalin Marinas , Will Deacon , Sandeepa Prabhu , William Cohen , Pratyush Anand , Steve Capper , , , Marc Zyngier , Mark Rutland , Petr Mladek , Viresh Kumar , John Blackwood , Feng Kan , Zi Shen Lim , Dave P Martin , Yang Shi , Vladimir Murzin , Kees Cook , "Suzuki K. Poulose" , Mark Brown , Alex =?iso-8859-1?Q?Benn=E9e?= , Ard Biesheuvel , Greg Kroah-Hartman , Mark Salyzyn , James Morse , Christoffer Dall , Andrew Morton , Robin Murphy , Jens Wiklander , Balamurugan Shanmugam , Subject: Re: [PATCH v12 10/10] kprobes: Add arm64 case in kprobe example module Message-ID: <20160517095714.GA25167@sha-win-210.asiapac.arm.com> References: <1461783185-9056-1-git-send-email-dave.long@linaro.org> <1461783185-9056-11-git-send-email-dave.long@linaro.org> MIME-Version: 1.0 In-Reply-To: <1461783185-9056-11-git-send-email-dave.long@linaro.org> User-Agent: Mutt/1.6.0 (2016-04-01) X-Originating-IP: [101.230.208.200] X-ClientProxiedBy: OS1PR01CA0041.jpnprd01.prod.outlook.com (10.164.162.23) To AM2PR08MB0498.eurprd08.prod.outlook.com (10.163.148.26) X-MS-Office365-Filtering-Correlation-Id: 11316bf3-5466-4654-5211-08d37e39c3f8 X-Microsoft-Exchange-Diagnostics: 1;AM2PR08MB0498;2:CPOZU5Pg4Y7gWK5y95HKHtyYAu611r/ug2ZzAZC+MQptWUqgHwDsmqTlt8KCM1L0h6y1VSTc9iTWsgFyv3VarndnSrEaZwcBmx1pUpoykAuKcZ7xiPq93U2obtsWe4VaO7iGMd20Fb1P4MjIycq79dfmbCM4amWl7N7OMwnZ9WzWbzPjerdq0UBNzU37pxx0;3:+Q1Xbuk4K4ChupWQg1HzJDG50f1dXrgX/cvmPyj31MkZwhlrSnhk2IrJg4F4t0Wn41njPY6DYL7mxb3ejfHGnz0MGZ07dLMbyCo69hl7SAMAgARGHIURuxm+AcUx/v/U;25:22XCQac5pEyF6ruqzwp51M97bykl5+lm4MAUza7JY0YbucBZdKL0yDIiXXInnImkVKjv7E+00X3vxhmTJJHiEdmjtyMYkIakeKfGjV7FJtGBT06yQHXG7y35kA2OR2OrAYJgRpz8CsWnkmHGvDIXyugW5eiH39rHExYSw6hHC3D4G0ygsnZrXkqDKoN4NgHlPKbLodqQOHl0PiFQtJ5e8WNecRR5f93YF5F8LQASIXnhauP8cCzyaWKodRsU/ujDEElkV9BmbT3OudQ6vYwao2h78cq/oDqd2PvBRELtb3zdC/f+ytLSHjQkQaUjz3d1hE8DcNmOXb2B1bJRlQUx25JMo+elaumzgjRDiygx9kLrPgqpoaaDAckUT9jZIInwhqxjjAP+fruWAs+Qt5cHAE0qBZ5L9Ap8F3O1nLRUt+Y=;20:jzsr5WyEAOsVJg0IEyqH45ag6OXu+u7sJ+Qu7qODV+znE5r617yFYKwYfTRkckgsbMlT8WInffFAL/cHRhoQ/DHGuSL3EZ93y9wRSgyHBj6bDBRR0FkS5uyioZl6/s/JZvv8zjYYiONF+c5Dj7WQKpOXKApZ3absN1gB7JYUbOw= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:AM2PR08MB0498; NoDisclaimer: True X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001)(6055026);SRVR:AM2PR08MB0498;BCL:0;PCL:0;RULEID:;SRVR:AM2PR08MB0498; X-Microsoft-Exchange-Diagnostics: 1;AM2PR08MB0498;4:GnEkAUtaU/J9xqqmeW/7kc/qOU9hvCr3xKQLfbn3t4K2TUCY4RaiKAaWJ6SUbh0u0aN+vpCBtAd+RnE3/VOOdUDomRQhwgBbrxQfYl9QWj+8kqcqDAI29hhXM0DshjOpnnl+pNv1MGTmWnN1zCZnfcoUp3y0MwmsC/xZ75chmvErSfIeeFLkFFlMWkJvjyiwoiiFmAjiliCpa4kDB7CM+Hlury2I5eUehuhw+ac7cN+XyCK4VoiW724SSIEKdc/TsTPeakmvlJT3EN68n0oAGI0PIMfc6J8jcaauLl4Zd9o6QE9fx3NEGdVHPb4rcu2+OV8FjX5ZLpN+lYRiWuwdqHrb7kyHU32G0s6mJ7JXcpofLmeZNtKnqqQdHOduivPNzs7IKXMPmrFKbROf52v0+A== X-Forefront-PRVS: 0945B0CC72 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(24454002)(97756001)(8676002)(47776003)(33656002)(110136002)(66066001)(86362001)(46406003)(42186005)(189998001)(4326007)(6116002)(586003)(23726003)(3846002)(1076002)(81166006)(5008740100001)(76176999)(50986999)(54356999)(77096005)(2950100001)(5004730100002)(92566002)(4001350100001)(2906002)(19580405001)(19580395003)(50466002);DIR:OUT;SFP:1101;SCL:1;SRVR:AM2PR08MB0498;H:sha-win-210.asiapac.arm.com;FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;AM2PR08MB0498;23:MF82IcfV4O5l8QGxkKaiDNI6qpgHjbA2wlrsdrInZX2DNTGNcpSRcAHpITTiu+07EFh46M3oyQmAljjdG9U78g+vsRevYoo4HgE888Cd/6SNGObpMrZ/GM03hoC54SX178q0lfd4GFqzfcp22aaHuISFaD8AqcCGg9EKajMvFpVhcpXHKq2F91un+yyz97YJZ7tXVdyj7fwIsipDvJJT5HevGp3yAQaROxs+hBkBnN6oFDanZhA+3yKlrf00mXwiXvudnTfG/H8fAG3V2Sh3xA72EvoKk8OKTyo4BVzil8nSwUiRhzQjy9YhW2TgPsppsWdKV7bN3IFbLmkdWEUEKofCTzULaAQzuowJ+0W2quRG4h1k4YpuEKYd9dII/c6CPyxCI22mt/0PzUpDkupNxGwWV2ZEKijFpCJhSFVqhQKzhZ8l9W4XJqSycQERaigB0x57kuckFND9FbcH2KZIAesj77sW9Q87ebWWxs6CjcdamlMidwbnpYYVj3LIB1Cci2+IYySOfTU5ESUHPynlXR4bG/6jucXuBXRneWkUstSxyhnEvVwXAQb7z5A0GcEZPXk4FhFQRGyEz4/Hs1H5+K9q4HxkuqQKtiM6iVym+FnfA6bJrhy1+oRwg5qdreTIntTCoBG0Sk2mbHOmodQtEvFtGqFS7JEI+cFsskrdm8dSDx2e9UQe56fNFMDcknASbG+o9G37ET5aOu5hAl+biCR3baDfN0B+pFmjoTEe1S21+d9nJ6wpGR6YKmRJdxRRSmrzDVuLqzLnaT8hlWLLlR22js7hjN3X1d8mikpvobar4zv0JU2v1lpcffa8uVqmvpgUv9WAlCaBv1I7HhIQyJmonwu8SY6bYuRXfECgfF86FSaq59yI6/qcsO5lo0BT5Hv/8wed6c92pUfBaQQNFQ== X-Microsoft-Exchange-Diagnostics: 1;AM2PR08MB0498;5:9eutjYeXrve+8bztJQRHcQFNhhkUWBNRCwf+Wvl0nuqWEo9Qc0GglEV+acmoAAVtxAvEdGJeNP1OvajI+du3vIj+7DInDiJAoe7jvjm3HK35a4+k/iIMjfJrPrhRGxfsiZqjFpII740+f8tr60tLvQ==;24:0njTxtPe5VYoh96VKAUPa+A0VR8a05pvfYpt5yt4AjeGA4BFlJraHeBLlrwO4K5G081QwGpDiBd27dJbRhNdjrbv9B9MP0xl2i3C/BQaNNo=;7:u8dc+soczLOV7Vp84oWvuk9Y0t5gj79vTxl8uNDATo9nc1Tksscboa0hyNLTKx+Qz7ZeltvdqwP3QWhRlHlgEP4Uk63OsB6CVFEDmZrjtwFyXypQ1fkJqhIDk2mlvlFn8JAX66TauFDnsLgGk3n982Fmszrt4GRyTEeDCCCua+wrwhG82fTuZaTv6kchiMi4;20:aUEggJu3u7YlHAsXGCkHxtY6rtMpJfj4QGNvGyLVe3iXkgTIPvt/IbyoXwXEC+i1AE0UO7c39Bf4NFmOYwxZyAUAR6Yw9nL+ncLVRxKZwHgFOO/tzIvJJuNkt5NGXBdzkJ/azx+ZJl2jLlVIXiBI1EO/+tM0Fzh+IJbM0iqWyms= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 May 2016 09:57:57.7466 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM2PR08MB0498 X-MC-Unique: jqp_wLKiT8WXJaUlj3-NQQ-1 Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: 8BIT Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 27, 2016 at 02:53:05PM -0400, David Long wrote: > From: Sandeepa Prabhu > > Add info prints in sample kprobe handlers for ARM64 > > Signed-off-by: Sandeepa Prabhu > --- > samples/kprobes/kprobe_example.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/samples/kprobes/kprobe_example.c b/samples/kprobes/kprobe_example.c > index 727eb21..0c72b8a 100644 > --- a/samples/kprobes/kprobe_example.c > +++ b/samples/kprobes/kprobe_example.c > @@ -42,6 +42,10 @@ static int handler_pre(struct kprobe *p, struct pt_regs *regs) > " ex1 = 0x%lx\n", > p->addr, regs->pc, regs->ex1); > #endif > +#ifdef CONFIG_ARM64 > + pr_info("pre_handler: p->addr = 0x%p, pc = 0x%lx\n", I think you miss the KERN_INFO here. > + p->addr, (long)regs->pc); > +#endif > > /* A dump_stack() here will give a stack backtrace */ > return 0; > @@ -67,6 +71,10 @@ static void handler_post(struct kprobe *p, struct pt_regs *regs, > printk(KERN_INFO "post_handler: p->addr = 0x%p, ex1 = 0x%lx\n", > p->addr, regs->ex1); > #endif > +#ifdef CONFIG_ARM64 > + pr_info("post_handler: p->addr = 0x%p, pc = 0x%lx\n", ditto. > + p->addr, (long)regs->pc); > +#endif thanks Huang Shijie