From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932158AbcEQNvc (ORCPT ); Tue, 17 May 2016 09:51:32 -0400 Received: from mail-pa0-f67.google.com ([209.85.220.67]:34604 "EHLO mail-pa0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751487AbcEQNvb (ORCPT ); Tue, 17 May 2016 09:51:31 -0400 Date: Tue, 17 May 2016 06:51:28 -0700 From: Tejun Heo To: Sergey Senozhatsky Cc: Calvin Owens , "Paul E. McKenney" , Andrew Morton , David Howells , Pranith Kumar , David Woodhouse , Johannes Weiner , Ard Biesheuvel , Petr Mladek , Vasily Averin , Thierry Reding , Geliang Tang , Ivan Delalande , linux-kernel@vger.kernel.org, kernel-team@fb.com Subject: Re: [RFC][PATCH] printk: Add option to append kernel version to the dict Message-ID: <20160517135128.GA4775@htj.duckdns.org> References: <51047c0f6e86abcb9ee13f60653b6946f8fcfc99.1463172791.git.calvinowens@fb.com> <20160515063643.GA817@swordfish> <20160516220252.GA2281534@devbig337.prn1.facebook.com> <20160517144257.GA582@swordfish> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160517144257.GA582@swordfish> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 17, 2016 at 11:42:57PM +0900, Sergey Senozhatsky wrote: > > > what if there is no place left for init_utsname() after > > > msg_print_ext_header() + msg_print_ext_body()? > > > > It ends up being truncated, like either of the preceeding calls would. > > well, I meant once it's truncated your matching doesn't work anymore. Given that most of the messages are written minding typical console widths, whether for editing or outputting, I don't think that's a practical concern. We're not talking about appending kilobytes worth of additional information here. Thanks. -- tejun