From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752829AbcERBcX (ORCPT ); Tue, 17 May 2016 21:32:23 -0400 Received: from eu-smtp-delivery-143.mimecast.com ([207.82.80.143]:23385 "EHLO eu-smtp-delivery-143.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752597AbcERBcV convert rfc822-to-8bit (ORCPT ); Tue, 17 May 2016 21:32:21 -0400 Date: Wed, 18 May 2016 09:31:32 +0800 From: Huang Shijie To: Mark Brown CC: Mark Rutland , Feng Kan , Catalin Marinas , Will Deacon , Viresh Kumar , Yang Shi , John Blackwood , Pratyush Anand , David Long , Zi Shen Lim , Dave P Martin , Petr Mladek , Vladimir Murzin , Steve Capper , Kees Cook , "Suzuki K. Poulose" , Marc Zyngier , Sandeepa Prabhu , William Cohen , , Alex =?iso-8859-1?Q?Benn=E9e?= , , Ard Biesheuvel , Greg Kroah-Hartman , , Mark Salyzyn , James Morse , Balamurugan Shanmugam , Andrew Morton , Robin Murphy , Jens Wiklander , Christoffer Dall Subject: Re: [PATCH v12 10/10] kprobes: Add arm64 case in kprobe example module Message-ID: <20160518013131.GA29570@sha-win-210.asiapac.arm.com> References: <1461783185-9056-1-git-send-email-dave.long@linaro.org> <1461783185-9056-11-git-send-email-dave.long@linaro.org> <20160517095714.GA25167@sha-win-210.asiapac.arm.com> <20160517102427.GD8104@sirena.org.uk> MIME-Version: 1.0 In-Reply-To: <20160517102427.GD8104@sirena.org.uk> User-Agent: Mutt/1.6.0 (2016-04-01) X-Originating-IP: [101.230.208.200] X-ClientProxiedBy: TY1PR01CA0006.jpnprd01.prod.outlook.com (10.161.131.144) To VI1PR08MB0510.eurprd08.prod.outlook.com (10.162.16.155) X-MS-Office365-Filtering-Correlation-Id: 54a0cc4a-1b7e-4eba-3a5d-08d37ebc3d42 X-Microsoft-Exchange-Diagnostics: 1;VI1PR08MB0510;2:0sXLvCNTUAcFch2tgwihlRMEbnUHgioyfS3tHe5qEAPb4xSKVj8mZZHDvBMXfbDPCss37GYva+zKyJYheyeo9XNTfZcJPCrfylmrH/fwyNhV9eED3tcb1RZxYsOBXozQulZDw1piMP4Vw1uapae0++2VuuEa6qEM16DU5OWE4szx6aRD/MVUzBRI1Ikz+NiG;3:Q6f/UoMirZ1k6fS/6KxqK3sSMYVD7RiTU1fpB6VTnn8QPDaGlYmaJTO3K3EjzkHFiqnBlS3RhDwjx81xzFY9Ghadx2hjgFh36SsdU8RqLvTtN4bv9ojptOZcr/m258qk;25:JwnBHPwBkJiuV0NJOtYd2bd2sz7Fqf+uxN9c96pEMfKWLJhbeQSRIrsE4o1SebMQbo9BQJpCg3387XO+5WdPNOTRuNTSfBpazM1ZRSNFvI1ts3XTn0Vsf10oe8hYnYmbr8sMToRFv/t/SZEiY0MIIVVE0qXFXvpOkK+CpeOW9sE/28ioVxx8OiF8OZxJjc55os0WWcRGDBgcFOIOYUSS7umcRR3vvjPaHg13ss19Ch9/8uonRx/J2sjuWv46OuF0l2s4mEDhSqwAy7toDe1jQIyYMt0fd2HytnbuRP6fa7kqsuouwye6UKT1341mSRH5DVovn7MDnqEJYCOHm+FCpGJbx8HzgXnWLK53sLA5OZ8gARd3gGGZXDSxE1+wwxj+SiKlyq9/Ci1Yc3ABj02v+uR2g0TaUjrXKeoHDGW4Fc4=;20:xIAJ0QZJro47pzcsO70v69Lxjn8OsKPfRgFPjWKYmNjIOCdmeTVCAxrf+YRSt2FKuAuMdhl7tgQ5IK9dUtPs9mGrcFtiFGYP5XeW/bhMhhG33kzjkK3mNqUEia65E8yIlYGowpFz32Bwi4TkwrVwUTNOSNZQMp7Y6nkV68k1Hws= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:VI1PR08MB0510; NoDisclaimer: True X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(6055026);SRVR:VI1PR08MB0510;BCL:0;PCL:0;RULEID:;SRVR:VI1PR08MB0510; X-Microsoft-Exchange-Diagnostics: 1;VI1PR08MB0510;4:5mG0krHvb+sQZVLiKHwt9iJpj7Rfr5UYaSjUSRpUkJwCA1yezxkMYztj21Snrp9EqYJo2d+2kzb5tXw+Z6FsZXD5K+2h3ITkqSTur3wQDd6q7nJYiWcJmn50YPvCHG5Cjh3nb+GTzrn2L8uKcFp9c9yiEtfP8VYevwefGGDnuNphcGdUOtj5bx5P5LkASCqCYgLlc00nyHx0JBNQXjWUnWnp68Si35aaG6B3vILgGIkB3xMFhe8ViRT2wwLi1CwzDE2l5ORXh03Yu+1JRnxlkyV2NGDPdJ0aL6s2Ga5yV6FOHfzPOFLYgcJoQxDFaAV7kWc/dwB+g1ETsqlvP8waz9wynSOOGT5WP/6EWj8jHwtvYcT67/CMUMi7OBYYJ1UH40KUDyyxusAqk7b6Pewi4w== X-Forefront-PRVS: 0946DC87A1 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(24454002)(81166006)(189998001)(110136002)(4326007)(97756001)(3846002)(6116002)(586003)(77096005)(83506001)(1076002)(23726003)(8676002)(33656002)(2950100001)(93886004)(5004730100002)(92566002)(76176999)(54356999)(50986999)(66066001)(46406003)(42186005)(47776003)(86362001)(2906002)(5008740100001)(4001350100001);DIR:OUT;SFP:1101;SCL:1;SRVR:VI1PR08MB0510;H:sha-win-210.asiapac.arm.com;FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;VI1PR08MB0510;23:Xl09ShLiO5DBcnOdPvKZ/06WrGrK05kRr6hE27zvS5TS54l3RkWX1h1nOLX98SwySstWgOQ9x/Qscz07m5RUTlJNZGtGFtfDZUHPlTpF6aI06zXQN2Wr+wlH7yTwpjMm4nYkeOGtlrRU8maZ0SdawP8+sPBS8ytk5vgxEJvuea6qBFodjxHulfL2/EndF5oUyIKbaiZNcPMv9naGXQWB+bKn3QwCho4thlRpP951p5V0kZDYi7ehsVAvkO+fIffqlfgPNvLEx1K1G9fCVe/D9xMuVGSjs42Je5PalKe9mVamwhZz/uJLX+/KKIsaCYRCSewx6LK+9Dfa/acFzbwbc30dqFMKAJeIE3INnNHSVXp4wRvr8goNb2MIMi1wi7Yfm3hTWzAq4hlleKkg6AHWZwbUIEjnGvNHy570cLDylZ3HaMCxTlVEhD4VDxsGkR88jCc6NfgJfR5FlM+HEbTr24BxwNhlIbP2qxDpArlzSE0FK3Vr2sbmbwuIRw4IA2CRWHNoWO8wHCSIkYPJIk/u8s9vs0AB9vnqP2mQFMRzS2WThQojiJ41s2W1piIIx86TbzqOLv9wyOlG0V9YoEdLqCY0/nPwXBYc+OmfB1mWu6A0UOZhGpEsIEQRK5oBL18zn47n4s8lV2GK6Uzf7krRvR20j8ojSu4n6ue+PLNeqlFcRTK7yUDAy1DHR9TpEPUOE/TsdihgCLl7EX4jqFB9rpjwaKtCHU3Lt3jUTTfN0IKwekxM4O3bUNsUAZkXOgrwIIkLu4oU0K7KShWO9JRuerUmllRzFwMUTp1o3/hTGnUuL569lpM2p1JxVoX49Aj4pCaBRg17aJQFdUI5YHVRqi6byaNtU1lxUTaTBKO80Wpw1tpbL8pM7p+/GxMVCvDu X-Microsoft-Exchange-Diagnostics: 1;VI1PR08MB0510;5:OxJT0GqWohRGDnmBF3bByYCMsgQTI1klvfnasnD4AoK5u/g7CjyvNI5as8OVUOiU3JlXMn8Khr0KkQTepFdlHNl4dOAWyz73MJn93I8Asz9KLmXDWoYoVdn3uViVjm6orch+6Cs9BkTVT6Gnin5HYA==;24:9T0wHDjrCKYVAMEWuTbmJIN+dbo5GwLKZnx0tcpknNAAmsZ2feF8luWxLFKwI2Hv5F4BLBXAyptIqGOvYDMIszJN3j7sW2idqnCQOz0i+Lo=;7:rwbWCqLhko0Z9JGa/z2mlCr4eZpAwEmbmmJisy5tXwj8dqQ4UIKWv15pGkTMiom8UlNimQYZCgSCGI4sZgjxv9y/kjKG3Ej10VQz5RepeBJWb9PekgcF3qWeJqD2ODxstfa8eOSqm2bMTD9WI/UUBuVvSqwatocu+kofEOONJNk5THuCz/O+uaWpcXPtqlVD;20:o5m5cLIy5Zc9NnjeGFjZVyaS8PvqVyeeo/SKI0k8vOHDmdAItAiRNuXEfEv//nlrAEsXntcHFd6C8YgLJhlsQLDtiGkZxyAKkoq3t7zXeXcIMC9Pw04tFWhoWCXSDmTKyKId15R7iNzSCg59OYvvE7Ejkw7M+Vy+qdAlHi+mR8g= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 May 2016 01:32:00.3571 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB0510 X-MC-Unique: yw5yb6H_T6GBTHv_j7G63w-1 Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: 8BIT Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 17, 2016 at 11:24:27AM +0100, Mark Brown wrote: > On Tue, May 17, 2016 at 05:57:33PM +0800, Huang Shijie wrote: > > On Wed, Apr 27, 2016 at 02:53:05PM -0400, David Long wrote: > > > > +#ifdef CONFIG_ARM64 > > > + pr_info("pre_handler: p->addr = 0x%p, pc = 0x%lx\n", > > > I think you miss the KERN_INFO here. > > That's what pr_info() does over printk() - it adds the KERN_INFO more > cleanly. sorry, I thought the "pr_info" to "printk" when I first read this code. thanks Huang Shijie