From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753477AbcERQnL (ORCPT <rfc822;w@1wt.eu>);
	Wed, 18 May 2016 12:43:11 -0400
Received: from mail.kernel.org ([198.145.29.136]:48422 "EHLO mail.kernel.org"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753320AbcERQnF (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 18 May 2016 12:43:05 -0400
Date: Wed, 18 May 2016 11:42:59 -0500
From: Rob Herring <robh@kernel.org>
To: David Mosberger-Tang <davidm@egauge.net>
Cc: srinivas.kandagatla@linaro.org, maxime.ripard@free-electrons.com,
        mark.rutland@arm.com, devicetree@vger.kernel.org, pawel.moll@arm.com,
        ijc+devicetree@hellion.org.uk, nicolas.ferre@atmel.com,
        linux-kernel@vger.kernel.org, galak@codeaurora.org,
        linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] drivers: nvmem: atmel-secumod: New driver for Atmel
 Secumod nvram
Message-ID: <20160518164259.GA28954@rob-hp-laptop>
References: <alpine.LNX.2.00.1605121505320.21379@nippy.intranet>
 <1463429830-20539-1-git-send-email-davidm@egauge.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1463429830-20539-1-git-send-email-davidm@egauge.net>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, May 16, 2016 at 02:17:10PM -0600, David Mosberger-Tang wrote:
> Signed-off-by: David Mosberger <davidm@egauge.net>
> ---
>  .../devicetree/bindings/nvmem/atmel-secumod.txt    |  46 ++++++++
>  drivers/nvmem/atmel-secumod.c                      | 125 +++++++++++++++++++++
>  2 files changed, 171 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/nvmem/atmel-secumod.txt
>  create mode 100644 drivers/nvmem/atmel-secumod.c
> 
> diff --git a/Documentation/devicetree/bindings/nvmem/atmel-secumod.txt b/Documentation/devicetree/bindings/nvmem/atmel-secumod.txt
> new file mode 100644
> index 0000000..85db709
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/nvmem/atmel-secumod.txt
> @@ -0,0 +1,46 @@
> += Atmel Secumod device tree bindings =
> +
> +This binding is intended to represent Atmel's Secumod which is found
> +in SAMA5D2 and perhaps others.
> +
> +Required properties:
> +- compatible: should be "atmel,sama5d2-secumod"
> +- reg: Should contain registers location and length of the RAM, followed

registers or RAM location?

"Should contain RAM location and length, ..."

> +       by register location and length of the Secumod controller.
> +
> += Data cells =
> +Are child nodes of secumod, bindings of which as described in
> +bindings/nvmem/nvmem.txt
> +
> +Example:
> +
> +    secumod@fc040000 {
> +            compatible = "atmel,sama5d2-secumod";
> +            reg = <0xf8044000 0x1420
> +                   0xfc040000 0x4000>;

You are missing ranges property.

> +            status = "okay";
> +
> +            #address-cells = <1>;
> +            #size-cells = <1>;
> +
> +            secram_auto_erasable@0000 {

Use '-' rather than '_' and drop leading 0s.

> +                    reg = <0x0000 0x1000>;
> +            };
> +            secram@1000 {
> +                    reg = <0x1000 0x400>;
> +            };
> +            ram@1400 {
> +                    reg = <0x1400 0x20>;
> +            };
> +    };
> +
> += Data consumers =
> +Are device nodes which consume nvmem data cells.
> +
> +For example:
> +
> +	ram {
> +		...
> +		nvmem-cells = <&ram>;
> +		nvmem-cell-names = "RAM";
> +	};